fix: runner doesnt work with in GitHub action#95
Merged
not-matthias merged 4 commits intomainfrom Jul 8, 2025
Merged
Conversation
This makes it easier to test since we can skip the upload and just focus on the benchmark running.
not-matthias
force-pushed
the
cod-1113-runner-doesnt-work-with-in-github-action
branch
from
fa9ee61 to
609ad98
Compare
not-matthias
requested review from
GuillaumeLagrange and
art049
and removed request for
art049
Contributor
|
and ci is failing |
art049
approved these changes
Jul 8, 2025
Member
art049
left a comment
art049
left a comment
There was a problem hiding this comment.
Only feedback is on the test strucure but mostly cosmetic
Member
|
And yes having passing CI |
not-matthias
force-pushed
the
cod-1113-runner-doesnt-work-with-in-github-action
branch
2 times, most recently
from
5e9338a to
8bfe53a
Compare
art049
reviewed
Jul 8, 2025
not-matthias
force-pushed
the
cod-1113-runner-doesnt-work-with-in-github-action
branch
from
8bfe53a to
2b24896
Compare
not-matthias
force-pushed
the
cod-1113-runner-doesnt-work-with-in-github-action
branch
from
2b24896 to
fe4de63
Compare
GuillaumeLagrange
approved these changes
Jul 8, 2025
not-matthias
deleted the
cod-1113-runner-doesnt-work-with-in-github-action
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the valgrind safe-run (missing quotation). Added tests for the walltime and valgrind executors. We're now also forwarding the system environment variables in the
systemd-runcmd.