fix: run with --scope to allow perf to trace the benchmark process#97
Merged
not-matthias merged 6 commits intomainfrom Jul 17, 2025
Merged
Conversation
not-matthias
requested review from
GuillaumeLagrange and
art049
and removed request for
GuillaumeLagrange
GuillaumeLagrange
requested changes
Jul 9, 2025
Contributor
GuillaumeLagrange
left a comment
GuillaumeLagrange
left a comment
There was a problem hiding this comment.
--scope actually inherits env from what I have see
export MY_VAR="hello"
systemd-run env | grep MY_VAR
systemd-run --scope env | grep MY_VAR
Member
Author
Doesn't work on my machine. Seems to only inherit the system env: > export THIS_IS_A_TEST="ZZZZZZZZZZZZZZZZZZZZZZZZZZZZZ"
> echo $THIS_IS_A_TEST
ZZZZZZZZZZZZZZZZZZZZZZZZZZZZZ
> sudo systemd-run --scope -- env | grep THIS_IS_A_TEST
Running as unit: run-p2129159-i2129160.scope; invocation ID: fdf21a15d503409891f434dd43243ad1 |
not-matthias
force-pushed
the
cod-1126-perf-traces-arent-copied-to-the-profile-folder
branch
2 times, most recently
from
6e374b2 to
11bf532
Compare
art049
requested changes
Jul 9, 2025
Member
art049
left a comment
art049
left a comment
There was a problem hiding this comment.
Is using source the only way to inherit the env?
not-matthias
force-pushed
the
cod-1126-perf-traces-arent-copied-to-the-profile-folder
branch
2 times, most recently
from
3769b98 to
cb76ebf
Compare
not-matthias
changed the title
art049
requested changes
Jul 15, 2025
not-matthias
force-pushed
the
cod-1126-perf-traces-arent-copied-to-the-profile-folder
branch
2 times, most recently
from
6223f14 to
f725a22
Compare
not-matthias
force-pushed
the
cod-1126-perf-traces-arent-copied-to-the-profile-folder
branch
from
f725a22 to
1f011ed
Compare
Member
Author
|
Added Note: the last 2 commits should be ignored, as they are merged from #99 (not sure why Github didn't recognize that, I'll close both once this PR is merged) |
art049
approved these changes
Jul 15, 2025
Member
There was a problem hiding this comment.
Nice! @GuillaumeLagrange I let you do the final review
not-matthias
deleted the
cod-1126-perf-traces-arent-copied-to-the-profile-folder
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately when running with --scope, we can't use
EnvironmentFilewhich is why I had to add it to the sh cmd. Perf can now trace the benchmark process again.