Skip to content

fix describe proxy impl #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
art049 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix describe proxy impl #197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 2 additions & 14 deletions libsql-server/src/rpc/proxy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -682,21 +682,9 @@ impl Proxy for ProxyService {

// FIXME: copypasta from execute(), creatively extract to a helper function
let lock = self.clients.upgradable_read().await;
let (connection_maker, _new_frame_notifier) = self
let connection_maker = self
.namespaces
.with(ctx.namespace().clone(), |ns| {
let connection_maker = ns.db.connection_maker();
let notifier = ns
.db
.as_primary()
.unwrap()
.wal_wrapper
.wrapper()
.logger()
.new_frame_notifier
.subscribe();
(connection_maker, notifier)
})
.with(ctx.namespace().clone(), |ns| ns.db.connection_maker())
.await
.map_err(|e| {
if let crate::error::Error::NamespaceDoesntExist(_) = e {
Expand Down