Breaking change: Make Rows and Row API more consistent.#227
Open
coco-speed wants to merge 1 commit intomainfrom
Open
Breaking change: Make Rows and Row API more consistent.#227coco-speed wants to merge 1 commit intomainfrom
coco-speed wants to merge 1 commit intomainfrom
Conversation
CodSpeed Performance ReportMerging #227 will not alter performanceComparing Summary
|
A few notes: I went the path of least resistance also assuming it would break fewer folks, i.e. make Row more like Rows and thus usize -> i32. Arguably, an unsigned type might be more appropriate both for length and indexes. I understand that the i32 stems from the sqlite bindings, which returns/accepts c_ints. Yet, Statement and Row made the jump to an unsigned, probably drawing the same conclusion, whereas Rows preserved its proximity to the c-bindings. This is probably an artifact? Also going on a limb, mapping c_int -> i32 is already a non-portable choice, with precision for c_int being platform dependent.
coco-speed
force-pushed
the
fork-1623-ignatz/align_row_and_rows
branch
from
67f2761 to
f510359
Compare
coco-speed
force-pushed
the
main
branch
8 times, most recently
from
e1cdddc to
f972697
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was created automatically by CodSpeed to track performance changes of the pull request tursodatabase/libsql#1623.
The original branch is fork-1623-ignatz/align_row_and_rows