Open
Conversation
A few notes: I went the path of least resistance also assuming it would break fewer folks, i.e. make Row more like Rows and thus usize -> i32. Arguably, an unsigned type might be more appropriate both for length and indexes. I understand that the i32 stems from the sqlite bindings, which returns/accepts c_ints. Yet, Statement and Row made the jump to an unsigned, probably drawing the same conclusion, whereas Rows preserved its proximity to the c-bindings. This is probably an artifact? Also going on a limb, mapping c_int -> i32 is already a non-portable choice, with precision for c_int being platform dependent.
between shadow tables and base table
we don't actually care, but let's do it for completeness
…s-ci2 enable more windows CI
…h-fix-vacuum fix behaviour of VACUUM for vector indices to make rowid consistent between shadow tables and base table
…libsql libsql: release v0.5.0
…ade-log libsql: downgrade failed prefetch log to debug
…ild-publish publish sqld debug builds to the separate image name
…ild-remove-digests remove digests artifacts from debug build step
Breaking change: Make Rows and Row API more consistent.
Fix JSON Number(f64) precision
…h-improve-random-row vector search: speed up random row selection query
…ntegration Namespace configurators
…h-allow-partial-index Vector search allow partial index
necessary to pass different underlying frames
…eplicator libsql wal replicator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was created automatically by CodSpeed to track performance changes of the pull request tursodatabase/libsql#1667.
The original branch is upstream/libsql-wal-rpc-server