Skip to content

Conversation

@lyannne
Copy link
Collaborator

@lyannne lyannne commented Jan 23, 2026

ℹ️ Issue

Closes #257

📝 Description

  1. Added logging and purpose statements to appropriate service methods.
  2. Documented routes in swagger.
  3. Made request body types in user.types.ts (used a json format so structure of data is clear to anyone testing).
  4. Changed change-roles route from POST to PATCH (since nothing is getting created; it's more like a user being moved).

✔️ Verification

N/A (just looked to see everything was there in swagger)

Test Changes

N/A

🏕️ (Optional) Future Work / Notes

A few concerns:

  • Should the delete-user route also be changed to DELETE instead of POST? I think that makes more sense, but the route would then need parameters instead of accepting a request body.
  • Every controller method has a guard, whether it's a user guard or admin one. This makes testing from the swagger UI kind of impossible. Thoughts?

Copilot AI review requested due to automatic review settings January 23, 2026 21:06
@lyannne lyannne linked an issue Jan 23, 2026 that may be closed by this pull request
@lyannne lyannne requested review from prooflesben and removed request for Copilot January 23, 2026 21:09
Copy link
Collaborator

@prooflesben prooflesben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make sure the routes work in swagger but everything lgtm(lets get this money).

@prooflesben prooflesben requested a review from yumi520 January 23, 2026 21:56
Copy link

@yumi520 yumi520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DEV - Generate docs and log code for the user module

4 participants