[SSF-107] Manufacturer Application Backend #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amywng
force-pushed
the
acw/SSF-107-manufacturer-app-backend
branch
from
605ec6d to
ac622e1
Compare
dburkhart07
requested changes
Jan 23, 2026
dburkhart07
left a comment
dburkhart07
left a comment
There was a problem hiding this comment.
A few very small changes, looks rly good so far 🔢
| enum: ManufacturerStatus, | ||
| enumName: 'manufacturers_status_enum', | ||
| }) | ||
| status: ManufacturerStatus; |
There was a problem hiding this comment.
I wonder if it is worth refactoring our application status enums for both manufacturer and pantry to be the same (since they are). Thoughts?
| ); | ||
| } | ||
|
|
||
| @Post('/approve/:manufacturerId') |
There was a problem hiding this comment.
Both of these should be Patch instead of Post I believe. While we are at it, I think we should change the same endpoints in the pantries controller.
| ], | ||
| }, | ||
| }) | ||
| @Post() |
There was a problem hiding this comment.
Personally, I feel like this should some form of name here. Can we give it something, like 'submit-application' or something like that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #107
📝 Description
✔️ Verification
Verified all endpoints on Postman and added controller tests.
🏕️ (Optional) Future Work / Notes
Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!