Open
Conversation
Seluj78
approved these changes
May 22, 2023
CantCode023
changed the title
Seluj78
reviewed
Mar 3, 2024
Seluj78
left a comment
Seluj78
left a comment
There was a problem hiding this comment.
Just a general quick feedback before I can do a full review
Seluj78
suggested changes
Mar 4, 2024
Seluj78
left a comment
Seluj78
left a comment
There was a problem hiding this comment.
I haven't reviewed the tests entirely, but what I've commented is a good bit so far haha :) I'd also recommend using pytest rather than unittest. It's faster and has a better plugin ecosystem. You can find some example tests here: https://github.com/Seluj78/shellhub-python/tree/main/tests
…score as thatt makes a name mangling
Seluj78
suggested changes
Mar 4, 2024
Blue-Robin-Taken
approved these changes
Mar 31, 2024
|
How do we get this pushed? It looks great! |
Added documentation
|
@Seluj78 @Blue-Robin-Taken, please review and merge it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day!
This pull request includes the following changes:
I made these changes to add a new feature in the 'Grepper' class. Here are more details about the changes:
Please let me know if you have any questions or feedback about these changes. Thanks for your time and consideration!
NEW CHANGES
hoping to be able to merge this pull request soon!
Best Regards,
CantCode023
Contacts: