Organize code that handles settings in the modal#31
Open
97morningstar wants to merge 20 commits intomasterfrom
Open
Organize code that handles settings in the modal#3197morningstar wants to merge 20 commits intomasterfrom
97morningstar wants to merge 20 commits intomasterfrom
Conversation
…at code livedgit status
[ADD] Update master
Updating master 2
[ADD] Kepler export button + modal
chrisgervang
reviewed
Aug 6, 2020
| @@ -0,0 +1,18 @@ | |||
| import React, {Component} from 'react'; | |||
Member
There was a problem hiding this comment.
I don't think you need this import
chrisgervang
reviewed
Aug 6, 2020
| webm:{ | ||
| quality: 1.5 | ||
| }, | ||
| filename: "Default Video Name" + " " + moment().format(DEFAULT_TIME_FORMAT).toString() |
Member
There was a problem hiding this comment.
You'll probably need to import moment and define DEFAULT_TIME_FORMAT.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #27
A more organized approach was needed so a folder named "render" was created for all render settings.
Inside, the following files were created:
The original plan was to have all settings as prop functions of the class
SettingsController, have a prop component of this class in RenderSettingsPanel that receives amapDataGlobalobject with all data from kepler, then this SettingsController prop would be passed to all places where a settings function is needed.Instead, all functions were relocated to the new files created and called directly. The mapDataGlobal object could not be passed.
The following changes are present because I tried to run the demo on a GitHub page:
The tilelayer was commented for the moment and the mapbox canvas restored in src/components/scene.js