Skip to content

192 add warning log when av related helm values are detected #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danc094codetogether merged 3 commits into from
Nov 28, 2025
Merged

192 add warning log when av related helm values are detected #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
09447f1
feat(helm): add warning log when deprecated AV settings are detected
danc094codetogether Nov 26, 2025
5e740ff
chore: add AV deprecation warning and clean up env vars
danc094codetogether Nov 28, 2025
1d2cd44
Merge branch 'dev' into 192-Add-warning-log-when-AV-related-Helm-valu…
danc094codetogether Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions charts/collab/templates/NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,21 @@ Application URL:
{{- $host := (urlParse .Values.codetogether.url).host }}
http{{ if $.Values.ingress.tls }}s{{ end }}://{{ $host }}{{ .path }}
{{- end }}

{{- if or .Values.av.enabled .Values.av.serverIP .Values.av.stunServers.enabled .Values.av.jitsiUrl }}

###############################################################################
# WARNING: A/V OPTIONS DEPRECATED
###############################################################################
Audio/Video options were detected in your Helm values:

av.enabled = {{ .Values.av.enabled | default "false" }}
av.serverIP = {{ .Values.av.serverIP | default "" }}
av.stunServers.enabled = {{ .Values.av.stunServers.enabled | default "false" }}
av.jitsiUrl = {{ .Values.av.jitsiUrl | default "" }}

A/V is no longer supported and these settings will be ignored by the server.
Please remove these values from your codetogether-values.yaml.
###############################################################################

{{- end }}
8 changes: 0 additions & 8 deletions charts/collab/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,14 +111,6 @@ spec:
- name: CT_AV_ENABLED
value: {{ .Values.av.enabled | quote }}

# ------------------------------
# A/V DEPRECATION NOTICE
# ------------------------------
{{- if or .Values.av.enabled .Values.av.serverIP .Values.av.stunServers.enabled .Values.av.jitsiUrl }}
- name: CT_AV_DEPRECATED_WARNING
value: "Audio/Video options detected in Helm values, but A/V is no longer supported and will be ignored."
{{- end }}

{{- if .Values.av.enabled }}
- name: CT_AV_LAN_IP
value: {{ .Values.av.serverIP | quote }}
Expand Down
Loading