Skip to content

Fixing 3.a. Logical Error-filter #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kamirave wants to merge 1 commit into
base: challenge/logical-error-filter
Choose a base branch
from
Open

Fixing 3.a. Logical Error-filter #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/components/TermList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,12 @@ export function TermList({ searchQuery, filter }: TermListProps) {
// Filter terms based on both status filter and search query
const filteredTerms = terms.filter(term => {
const matchesFilter = filter === 'understood' ? term.understood : !term.understood;
// Logical Error: Search is case-sensitive instead of case-insensitive
const matchesSearch = searchQuery.trim() === '' || term.term.includes(searchQuery.trim());
const lowerQuery = searchQuery.trim().toLowerCase();
const matchesSearch = lowerQuery === '' || term.term.toLowerCase().includes(lowerQuery);
return matchesFilter && matchesSearch;
});


return (
<div className="space-y-4">
{filteredTerms.map((term) => {
Expand Down