London | 25-ITP-May | Houssam Lahlah | Sprint 2 | Course work sprint 2 #783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed console.log to use address.houseNumber instead of address[0] - Ensures correct display of house number in output
- Replaced invalid for...of loop on object with Object.values() - Ensures all property values of author are logged without errors
- Replaced object string output with ingredients joined by newline - Ensures each ingredient is printed on its own line as intended
- Added 'contains' function to verify if an object has a given property key. - Handles invalid inputs gracefully by returning false. - Added comprehensive tests for empty objects, existing/non-existing properties, and invalid inputs.
- Created 'createLookup' function file with module export. - Added a test.todo placeholder for creating country-currency code lookup functionality. - Setup initial structure for implementation and testing.
- Updated 'parseQueryString' to correctly parse query string values containing '=' characters. - Added test to verify parsing of complex values like 'equation=x=y+1'. - Ensured other edge cases handled appropriately.
- Implemented 'tally' function to return an object with counts of each unique item. - Throws error for invalid inputs (non-array). - Added tests for empty arrays, duplicate counting, and invalid input error throwing.
- Changed from array-style access (address[0]) to object property access (address.houseNumber) - Logs the house number correctly now
- Replaced invalid for...of loop over object with Object.values() to log all property values
- Added a for loop to print each ingredient on its own line - Improved readability of recipe output
- Replaced incorrect property assignment with dynamic key - Added tests for numeric and string values, and edge cases
- Converted coin keys (e.g. "1p") to numeric values before multiplication - Fixed issue where multiplying string by number caused NaN result - Added tests to verify correct total calculation and empty till case - test case for handle large quantities
HoussamLh
added
the
Needs Review
Contributor
|
This branch is not clean. I have left you suggestion to fix the problem in your other PR. |
cjyuan
added
Reviewed
|
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
1 similar comment
|
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
This pull request for syn my fork and updating my branch.
Questions
Please, Let me know if there is anything else went wrong?