Skip to content

Glasgow | 25-ITP-SEP | Shreef Ibrahim | Sprint 3| Quote Qenerator App #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shreefAhmedM wants to merge 2 commits into from
Closed

Glasgow | 25-ITP-SEP | Shreef Ibrahim | Sprint 3| Quote Qenerator App #796

shreefAhmedM wants to merge 2 commits into from

Conversation

@shreefAhmedM
Copy link

@shreefAhmedM shreefAhmedM commented Oct 15, 2025

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Here is a basic implementation of Quote Qenerator App using HTML and JavaScript

@shreefAhmedM shreefAhmedM added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 15, 2025
LonMcGregor
LonMcGregor reviewed Oct 27, 2025
View reviewed changes
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work,I only see a minor issue in the styling

Sprint-3/quote-generator/style.css
Copy link

@LonMcGregor LonMcGregor Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my screen, this page shows an unnecessary vertical scrollbar - can you find out how to fix that?

Copy link
Author

@shreefAhmedM shreefAhmedM Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated.

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 27, 2025
LonMcGregor
LonMcGregor reviewed Oct 28, 2025
View reviewed changes
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 28, 2025
@shreefAhmedM shreefAhmedM mentioned this pull request Nov 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shreefAhmedM @LonMcGregor @illicitonion