London|ITP-September-2025|Alexandru Pocovnicu|Sprint 1|Implement #806

alexandru-pocovnicu · 2025-10-30T11:38:36Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

I implemented functions to satisfy pre-written test requirements

…median calculation logic

…prove null handling

…edundant code

…edian calculation logic

github-actions · 2025-10-30T11:38:52Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-30T11:38:53Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-30T11:38:55Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-30T11:38:57Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-30T11:38:58Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-30T11:39:03Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

Sprint-1/fix/median.js

Sprint-1/implement/dedupe.js

Sprint-1/implement/dedupe.test.js

Sprint-1/implement/max.js

Sprint-1/implement/sum.js

Sprint-1/implement/sum.test.js

Sprint-1/implement/sum.js

github-actions · 2025-11-08T15:51:24Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

…iltering

github-actions · 2025-11-23T09:37:11Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2025-11-23T09:37:14Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2025-11-23T10:53:27Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2025-11-23T10:54:53Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2025-11-23T10:57:35Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

cjyuan

Can you also fix the PR title format (in order to silence the automated check)?

Sprint-1/implement/dedupe.test.js

cjyuan · 2025-11-23T10:53:37Z

Sprint-1/implement/sum.js

  if (elements.length === 0) {
    return 0;
  }
-  if (elements.length === 1) {
-    return elements[0];
-  }
-  if (elements.every((element) => typeof element !== "number")) {
-    return NaN;
-  }
+
  const filteredElements = elements.filter(
    (element) => typeof element === "number"
  );
+  if (filteredElements.length === 0) {
+    return NaN;
+  }


Both of the following function calls return NaN. How should the caller tell which case it is when the returned value is NaN?

sum(["A", "B"]); // Case 1 sum([NaN, 1, 2, 3]); // Case 2

Sprint-1/implement/sum.test.js

github-actions · 2025-11-23T11:11:10Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

cjyuan

Changes look good!

It's a best practice to respond all reviewer's comments instead of just making changes quietly. Please practice that in future PRs.

alexandru-pocovnicu added 19 commits October 24, 2025 10:12

Add initial test file for mean calculations

71fa218

Add mean.js file for mean calculations

927769b

Remove mean.js and mean.test.js files

a393af9

Update dependencies in package-lock.json to latest versions

057a7dd

Refactor calculateMedian function to handle mixed values and improve …

bc5e43c

…median calculation logic

Add workspace configuration for project structure and Jest settings

b13a731

Refactor calculateMedian function to filter non-numeric values and im…

552eb4c

…prove null handling

Refactor calculateMedian function to improve null checks and remove r…

1e0393e

…edundant code

Refactor calculateMedian function to streamline sorting and improve m…

b78089c

…edian calculation logic

Add tests for findMax function to cover various input scenarios

4f6b45e

Refactor findMax function to enhance readability and maintainability

5d670ec

Implement tests for sum function to validate various input scenarios

879eb0e

Implement sum function to calculate the sum of an array of numbers

157b5f7

Implement tests for dedupe function to validate various input scenarios

c85cfda

Implement dedupe function to remove duplicate values from an array

5619c22

Format code for consistency and readability in dedupe function

abd3a43

Format dedupe tests for consistency and readability

ee2fd08

Fix spacing in comment for consistency in includes tests

584bd6f

Refactor includes function to use for...of loop for improved readability

908c81e

alexandru-pocovnicu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 30, 2025

cjyuan reviewed Nov 8, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 8, 2025

alexandru-pocovnicu added 4 commits November 23, 2025 08:52

add test to check that dedupe returns a copy and not the original array

235fbc6

Refactor sum function to improve NaN handling and streamline number f…

9fefde9

…iltering

changed test for decimal numbers from toEqual to toBeCloseTo

c230c17

deleted unnecessary code

843f101

alexandru-pocovnicu added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 23, 2025

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 23, 2025

alexandru-pocovnicu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 23, 2025

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 23, 2025

alexandru-pocovnicu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 23, 2025

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 23, 2025

alexandru-pocovnicu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 23, 2025

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 23, 2025

cjyuan reviewed Nov 23, 2025

View reviewed changes

cjyuan added the Reviewed Volunteer to add when completing a review with trainee action still to take. label Nov 23, 2025

alexandru-pocovnicu added 2 commits November 23, 2025 11:35

updated test to check if dedupe returns a copy of the original array

49a93ca

filtered out NaN from the elements

3d8bc26

alexandru-pocovnicu added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 23, 2025

cjyuan reviewed Nov 23, 2025

View reviewed changes

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 23, 2025

alexandru-pocovnicu closed this by deleting the head repository Jan 1, 2026

Uh oh!

London|ITP-September-2025|Alexandru Pocovnicu|Sprint 1|Implement #806

London|ITP-September-2025|Alexandru Pocovnicu|Sprint 1|Implement #806

Uh oh!

Conversation

alexandru-pocovnicu commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Uh oh!

github-actions bot commented Oct 30, 2025

Uh oh!

github-actions bot commented Oct 30, 2025

Uh oh!

github-actions bot commented Oct 30, 2025

Uh oh!

github-actions bot commented Oct 30, 2025

Uh oh!

github-actions bot commented Oct 30, 2025

Uh oh!

github-actions bot commented Oct 30, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 8, 2025

Uh oh!

github-actions bot commented Nov 23, 2025

Uh oh!

github-actions bot commented Nov 23, 2025

Uh oh!

github-actions bot commented Nov 23, 2025

Uh oh!

github-actions bot commented Nov 23, 2025

Uh oh!

github-actions bot commented Nov 23, 2025

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cjyuan Nov 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Nov 23, 2025

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

alexandru-pocovnicu commented Oct 30, 2025 •

edited

Loading