London | ITP-Sep-25 | Gislaine Della Bella | Data Groups | Sprint- 1 #810

Della-Bella · 2025-11-02T20:45:09Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

// It is not my solution I got help with AI. I confess I need to undestand more those 3 methodos to think how to get to this. // I will come back to it later. For now i will keep practicing more katas because they are help me.

github-actions · 2025-11-02T20:45:19Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-02T20:45:30Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-09T14:31:30Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-15T12:16:11Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-15T12:16:24Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

ckirby19

Great work, mostly comments on formatting. Let me know if you are stuck on anything

ckirby19 · 2025-11-15T12:20:11Z

Sprint-1/fix/median.js

+// }
+
+// Ignore this Commit
+// It is not my solution I got help with AI. I confess I need to undestand more those 3 methodos to think


I appreciate your honesty :D

ckirby19 · 2025-11-15T12:20:41Z

Sprint-1/fix/median.js

+  }
+
+  //Filter non-numeric values and create a new array of only numbers
+


Generally we don't leave a line between the comment and the code the comment is related to

ckirby19 · 2025-11-15T12:30:32Z

Sprint-1/fix/median.js

+  }
+
+  //Sort the numeric list
+  const sortedList = [...numericList].sort((a, b) => a - b);


Can you explain why [...numericList] is needed? What would happen if I did numericList.sort instead?

because it is better not to change the original array in case I want to use it later in my code. I'm sorting a "copy" of it.

ckirby19 · 2025-11-15T12:33:58Z

Sprint-1/implement/dedupe.js

@@ -1 +1,13 @@
-function dedupe() {}
+function dedupe(arr) {
+  let result = [];


Does result have to be let here, or can it be const?
Same for item - can it be const?

I got it now. result should be const because the reference to the array doesn't need to be changed. For item in the , it can also be const, as a new item variable is declared for each iteration, because it's not reassigned within a single loop cycle.

ckirby19 · 2025-11-15T12:34:42Z

Sprint-1/implement/dedupe.test.js

 // Given an array with no duplicates
 // When passed to the dedupe function
 // Then it should return a copy of the original array
+test(" Given an array with no duplicates", () => {


No need for the space between " and G

ckirby19 · 2025-11-15T12:41:38Z

Sprint-1/implement/max.test.js

 // Then it should return that number
+test("given an array with 1 number, it returns the number ",() => {;
+  const inputMax1 = [3];
+    const result = findMax(inputMax1);


Formatting: ensure all lines have the same indentation. Same for all tests below

ckirby19 · 2025-11-15T12:44:27Z

Sprint-1/implement/sum.js

+
+  let onyNumbers = theArray.filter(item => typeof item === 'number');
+
+


Formatting:

Misspelling of onyNumbers

We usually don't leave two empty lines between code like this

ckirby19 · 2025-11-15T12:45:28Z

Sprint-1/implement/sum.js

-function sum(elements) {
+function sum(theArray) {
+
+  let onyNumbers = theArray.filter(item => typeof item === 'number');


Does this need to be let?

No, It can be const because the variable is assigned once with the filtered array.

ckirby19 · 2025-11-15T12:45:54Z

Sprint-1/implement/sum.test.js

 // When passed to the sum function
 // Then it should return that number

+test("given an array with 1 number, it returns the sam number", () => {


Misspelling: sam

ckirby19 · 2025-11-15T12:47:09Z

Sprint-1/refactor/includes.js

+
+
+function includes(list,target){
+  for (let value of list) {


Does this need to be let?

I start to undestand now these const and let .. i thought let would always give me less risk of error, but I can see the opposite now.

thank you for your reviwes ;)

github-actions · 2025-11-15T12:50:24Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-15T12:50:24Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

Della-Bella · 2025-11-16T12:16:35Z

I start to undestand now these const and let .. i thought let would always give me less risk of error, but I can see the opposite now.

thank you for your reviwes ;)

github-actions · 2025-11-16T12:17:39Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-16T12:17:39Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data Groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

Della-Bella added 5 commits October 28, 2025 22:46

Max Excercise

4938239

Sum Excercise

0d9e98c

Dedupe Excercise

b647f3a

Includes Excercise

6cdb275

Ignore this Commit

8ad77a6

// It is not my solution I got help with AI. I confess I need to undestand more those 3 methodos to think how to get to this. // I will come back to it later. For now i will keep practicing more katas because they are help me.

Della-Bella added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 2, 2025

ckirby19 added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 15, 2025

This comment was marked as duplicate.

Sign in to view

ckirby19 reviewed Nov 15, 2025

View reviewed changes

ckirby19 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Nov 15, 2025

Della-Bella added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 16, 2025

illicitonion closed this Jan 7, 2026

		}

		//Filter non-numeric values and create a new array of only numbers


		let onyNumbers = theArray.filter(item => typeof item === 'number');

Uh oh!

London | ITP-Sep-25 | Gislaine Della Bella | Data Groups | Sprint- 1 #810

London | ITP-Sep-25 | Gislaine Della Bella | Data Groups | Sprint- 1 #810

Uh oh!

Conversation

Della-Bella commented Nov 2, 2025

Learners, PR Template

Changelist

Questions

Uh oh!

github-actions bot commented Nov 2, 2025

Uh oh!

github-actions bot commented Nov 2, 2025

Uh oh!

github-actions bot commented Nov 9, 2025

Uh oh!

github-actions bot commented Nov 15, 2025

Uh oh!

github-actions bot commented Nov 15, 2025

Uh oh!

This comment was marked as duplicate.

Uh oh!

ckirby19 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 15, 2025

Uh oh!

github-actions bot commented Nov 15, 2025

Uh oh!

Della-Bella commented Nov 16, 2025

Uh oh!

github-actions bot commented Nov 16, 2025

Uh oh!

github-actions bot commented Nov 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants