London | ITP-SEP25 | Shaghayegh Shirinfar | Sprint 3 | Alarm Clock

[shaghayeghfar]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

I followed the instruction in the readme files and add the code were I was asked.

[github-actions]

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

[github-actions]

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

[github-actions]

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

[A-O-Emmanuel]

Your alarm clock works, however I noticed that when the "set alarm" button is clicked and the input field is empty, the alarm goes off and the time reads "00:-1", every other functionality works, just that.

[shaghayeghfar]

@A-O-Emmanuel
Dear Emmanuel

Thank you very much for reviewing my pull request and for your advice. I really appreciate it.
I fixed the issue you mentioned by adding a check to ensure that the input is not null.

thanks again for your help and time.

[A-O-Emmanuel]

Good job! Your code works and does everything it’s supposed to. In real projects, you might want to:

1. Make sure the user can’t enter letters or negative numbers.
   2 Stop multiple countdowns if someone clicks the button more than once.
   3 Save the DOM elements in a variable instead of looking them up every second, to make it a bit faster.

But I think for this exercise what you have done is okay,

[A-O-Emmanuel]

Also, attend to this : "Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed)."

[shaghayeghfar]

@A-O-Emmanuel

Dear Emmanuel,

Thank you for your checking and feedback. I am a bit confused — I’m not sure what you mean by “ticking out things,” because I reviewed the checklist and I believe I have already ticked everything and removed the other items from my PR.

Thank you again for your help. Is there anything else I need to do to move this PR to “completed” status?

I appreciate your time and support.

[A-O-Emmanuel]

I can confirm you've fixed the issue, and the alarm clock app, looks good enough for me, good job!