Glasgow | 25-ITP-SEP | Alaa Tagi | Sprint 1| Coursework/sprint 1 #824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alaa-Tagi
added
📅 Sprint 1
cjyuan
reviewed
Nov 20, 2025
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Can you check if any of this general feedback can help you further improve your code?
https://github.com/CodeYourFuture/Module-Data-Groups/blob/sprint-1-feedback/Sprint-1/feedback.md
Doing so can help reviewers speed up the review process. Thanks.
cjyuan
added
Reviewed
Author
|
@cjyuan I have gone through all the general feedback for Sprint-1 and made the improvements to the files that required changes. thanks |
Alaa-Tagi
added
Needs Review
cjyuan
reviewed
Nov 29, 2025
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Changes look great! Well done!
Comment on lines
+40
to
+43
| test("given an array with decimal numbers, returns the correct total sum", () => { | ||
| expect(sum([1.5, 2.5, 3.5])).toBe(7.5); | ||
| }); | ||
|
|
Contributor
There was a problem hiding this comment.
Why not use .toBeCloseTo()?
cjyuan
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I have created a PR with completed all the tasks.
Questions
NO questions.