Glasgow | 25-ITP-SEP | Fares Bakhet | Sprint 1 | Coursework/sprint 1 #825

Fares-Bakhet · 2025-11-08T17:16:42Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

I have opened this RP after completing the tasks required.

Questions

No questions.

github-actions · 2025-11-08T17:16:55Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint-1) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-08T17:17:15Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint-1) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-08T17:17:16Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint-1) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-08T17:17:17Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint-1) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-11-08T17:18:06Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Sprint-1) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

Sprint-1/fix/median.js

Sprint-1/implement/dedupe.test.js

cjyuan · 2025-11-15T14:55:44Z

Sprint-1/implement/max.js

+    if (Math.sign(num) === -1 && num.length > 1) {
+      return Math.max(...num);
+    }
+    if (num.isDecimal === true) {


What is .isDecimal?

@cjyuan , it's supposed to be isInteger

cjyuan · 2025-11-15T15:02:46Z

Sprint-1/implement/max.js

+    if (typeof num[i] !== "number") {
+      num.splice(i, 1);
+      i--;
+    }


Currently this function may not work for some arrays. For example, when nums is ["A"].

Instead of deleting elements from num (which could be an undesired side effect), consider using .filter() to filter elements that are numbers to a separate array, and then find the largest value in the new array.

Doing so could also simplify the code.

cjyuan · 2025-11-15T15:06:06Z

Sprint-1/implement/sum.test.js

+test("given an array with decimal numbers, returns the correct total sum", () => {
+  expect(sum([1.5, 2.5, 3.5])).toBe(7.5);
+});



Decimal numbers in most programming languages (including JS) are internally represented in "floating point number" format. Floating point arithmetic is not exact. For example, the result of 46.5678 - 46 === 0.5678 is false because 46.5678 - 46 only yield a value that is very close to 0.5678. Even changing the order in which the program add/subtract numbers can yield different values.

So the following could happen

expect( 1.2 + 0.6 + 0.005 ).toEqual( 1.805 ); // This fail expect( 1.2 + 0.6 + 0.005 ).toEqual( 1.8049999999999997 ); // This pass expect( 0.005 + 0.6 + 1.2 ).toEqual( 1.8049999999999997 ); // This fail console.log(1.2 + 0.6 + 0.005 == 1.805); // false console.log(1.2 + 0.6 + 0.005 == 0.005 + 0.6 + 1.2); // false

Can you find a more appropriate way to test a value (that involves decimal number calculations) for equality?

Suggestion: Look up

Checking equality in floating point arithmetic in JavaScript

Checking equality in floating point arithmetic with Jest

cjyuan

Changes look good.

cjyuan · 2025-11-26T22:55:08Z

Sprint-1/implement/max.js

+    return Math.max(...numbers);
+  }
+
+  return arr[arr.length - 1];


This is an odd choice of value to return.

Is there any value you don't expect findMax() to ever return?

Fares-Bakhet added 9 commits November 4, 2025 16:18

Fix the implementation

dcdec45

Implement a Deduplicate function

589c8d9

Run tests for the Deduplicate function

3ebe1f9

Implement findMax function

8817635

Adding tests for max.js file

744af5d

Implementing a sum function

61a84ce

Run tests for the sum.js file

1762ae0

Editing the code

bf825f1

Refactoring the implementation

c8d3734

Fares-Bakhet added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. labels Nov 8, 2025

cjyuan added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 15, 2025

cjyuan reviewed Nov 15, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Nov 15, 2025

Fares Bakhet added 5 commits November 26, 2025 16:26

fix deupe.test.js file

cd9b36a

fix file

9420f6a

fix max.js file

c8f6f8f

Editing max.js file

89e0e23

Editing sum.test.js file

8495512

Fares-Bakhet removed the Reviewed Volunteer to add when completing a review with trainee action still to take. label Nov 26, 2025

Fares-Bakhet added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 26, 2025

cjyuan reviewed Nov 26, 2025

View reviewed changes

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 26, 2025

illicitonion closed this Jan 7, 2026

Uh oh!

Glasgow | 25-ITP-SEP | Fares Bakhet | Sprint 1 | Coursework/sprint 1 #825

Glasgow | 25-ITP-SEP | Fares Bakhet | Sprint 1 | Coursework/sprint 1 #825

Uh oh!

Conversation

Fares-Bakhet commented Nov 8, 2025

Changelist

Questions

Uh oh!

github-actions bot commented Nov 8, 2025

Uh oh!

github-actions bot commented Nov 8, 2025

Uh oh!

github-actions bot commented Nov 8, 2025

Uh oh!

github-actions bot commented Nov 8, 2025

Uh oh!

github-actions bot commented Nov 8, 2025

Uh oh!

Uh oh!

Uh oh!

cjyuan Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

Fares-Bakhet Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 15, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants