London | 25-ITP-September |Gislaine Della Bella | Sprint 2 | Debug #827
Conversation
Della-Bella
added
the
Needs Review
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Wrong number of parts separated by |s If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
1 similar comment
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Wrong number of parts separated by |s If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
ckirby19
added
the
Review in progress
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Wrong number of parts separated by |s If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
ckirby19
removed
the
Needs Review
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Wrong number of parts separated by |s If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
ckirby19
left a comment
ckirby19
left a comment
There was a problem hiding this comment.
Good work so far, but there are a lot of formatting issues here - please ensure:
- Indentations are consistent and correct
- That there are no extra blank lines
This will really help reviewers to understand your code better
Sprint-2/debug/address.js
Outdated
| @@ -1,5 +1,7 @@ | |||
| // Predict and explain first... | |||
|
|
|||
| // adress is a object and use label to acess the information not a index | |||
There was a problem hiding this comment.
Misspelling: adress, acess, a index
Otherwise, very good! Correct
| console.log(value); | ||
| const onlyValues = Object.values(author); | ||
| for (const value of onlyValues) { | ||
| } |
There was a problem hiding this comment.
Is there a reason you are closing the bracket right here?
There was a problem hiding this comment.
got it .it was a mistake. I had an empty loop. fixed. thanks
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Formatting: no need for the extra blank lines, usually we have a maximum of one blank line
Sprint-2/debug/author.js
Outdated
| art: 95 | ||
| }; | ||
|
|
||
| let totalSum = 0; |
There was a problem hiding this comment.
Formatting, please ensure all lines have the same indentation
|
|
||
|
|
||
| const studentScores = { | ||
| math: 85, |
There was a problem hiding this comment.
We usually have the object keys and values indented one more line to make it easier to read
Sprint-2/debug/author.js
Outdated
|
|
||
| const ingredientsList = Object.keys(recipe.ingredients); | ||
|
|
||
|
|
ckirby19
added
Reviewed
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Wrong number of parts separated by |s If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
1 similar comment
|
Your PR's title isn't in the expected format. Please check the expected title format, and update yours to match. Reason: Wrong number of parts separated by |s If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
Della-Bella
changed the title
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
Della-Bella
added
Complete
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
1 similar comment
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
3 participants
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.