Skip to content

Conversation

@anosidium
Copy link

@anosidium anosidium commented Nov 10, 2025

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I completed all the tasks.

Questions

I don't understand why the requirements are structured the way they are.

  • The button label is "Stop Alarm", but the function called is pauseAlarm(), not stopAlarm(), and all it does is pause the audio track, it doesn’t actually stop the alarm. Why?

In the Extra Tasks section, it says:

Could you add pause functionality so that the countdown stops and then you restart it later?

This is confusing, because “pause” normally means to temporarily suspend the timer, not to stop it completely. Yet, the instruction says “countdown stops and then restart it later”, which sounds more like stopping and restarting from the beginning rather than pausing and resuming.

I think it would make more sense like this:

  • The Start Alarm button starts the timer, then renames itself to Pause, which temporarily suspends the timer and renames itself to Resume to continue the countdown.
  • The Stop Alarm button completely stops the timer.

@anosidium anosidium added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 10, 2025
@A-O-Emmanuel A-O-Emmanuel added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 12, 2025
Copy link

@A-O-Emmanuel A-O-Emmanuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your alarm clock app works. Basically the core functionality the alarm clock should have works, and I have to commend you for attempting the extra tasks. One thing i noticed is when I click the stop alarm button, the screen keeps on blinking. But still a good work!

@A-O-Emmanuel A-O-Emmanuel added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants