Skip to content

London | 25-ITP-Sep | Shghayegh Shirinfar | Sprint 3 | qoute-generator #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shaghayeghfar wants to merge 1 commit into from
Closed

London | 25-ITP-Sep | Shghayegh Shirinfar | Sprint 3 | qoute-generator #831

shaghayeghfar wants to merge 1 commit into from

Conversation

@shaghayeghfar
Copy link

@shaghayeghfar shaghayeghfar commented Nov 10, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I read the instruction and added some code in the qoutes.js file and make sure that it works correctly.

@github-actions
Copy link

github-actions bot commented Nov 10, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@shaghayeghfar shaghayeghfar added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 10, 2025
@github-actions
Copy link

github-actions bot commented Nov 10, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@shaghayeghfar shaghayeghfar mentioned this pull request Nov 10, 2025
Open
@A-O-Emmanuel A-O-Emmanuel added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 12, 2025
A-O-Emmanuel
A-O-Emmanuel reviewed Nov 12, 2025
View reviewed changes
Copy link

@A-O-Emmanuel A-O-Emmanuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your quote generator app works according to the specification, It could use a bit more styling, but it's still a good work!

@A-O-Emmanuel A-O-Emmanuel added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@A-O-Emmanuel A-O-Emmanuel A-O-Emmanuel left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shaghayeghfar @A-O-Emmanuel @illicitonion