London | 25-ITP-September | Ammad Ur Rehman | Sprint 3 | [TECH ED] Complete sprint 2 exercises #836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t.js file to write tests.
anosidium
added
the
Needs Review
cjyuan
reviewed
Nov 21, 2025
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Great work. I just have a few suggestions.
Comment on lines
1
to
9
| function tally(array) { | ||
| if (!Array.isArray(array)) throw new Error("array is not an array!"); | ||
|
|
||
| return array.reduce((accumulator, currentValue) => { | ||
| const value = accumulator[currentValue]; | ||
| accumulator[currentValue] = value ? value + 1 : 1; | ||
| return accumulator; | ||
| }, {}); | ||
| } |
Contributor
There was a problem hiding this comment.
Does the following function call returns the value you expect?
tally(["toString", "toString"]);
Suggestion: Look up an approach to create an empty object with no inherited properties.
Author
There was a problem hiding this comment.
Thanks for the review, I didn't know about this particular case! 😮
cjyuan
added
Reviewed
anosidium
added
Needs Review
cjyuan
reviewed
Nov 21, 2025
| console.log( | ||
| `titie: ${recipe.title}, serves: ${ | ||
| recipe.serves | ||
| }, ingredients: ${recipe.ingredients.join(", ")}` |
Contributor
There was a problem hiding this comment.
The requirement is "Each ingredient should be logged on a new line". :D
Author
There was a problem hiding this comment.
Oops! Then why did you suggest Array.prototype.join()? My original implementation did exactly that.
Contributor
There was a problem hiding this comment.
You could join with new line character.
cjyuan
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I completed all the exercises and skipped the stretch exercises
Questions
I’d like to point out the
parseQueryString()function, we should ensure it properly handles percent-encoded characters (e.g.,%3Dfor=and%2Bfor+).