Skip to content

Glasgow | 25-ITP-Sep | Abraham-Habte | Sprint 3| alarmClock app #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Abrsh100 wants to merge 2 commits into from
Closed

Glasgow | 25-ITP-Sep | Abraham-Habte | Sprint 3| alarmClock app #842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed6a4c0
modifing html and js
Abrsh100 Nov 15, 2025
5de1d20
change the date input in to seconds
Abrsh100 Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 48 additions & 1 deletion Sprint-3/alarmclock/alarmclock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,50 @@
function setAlarm() {}
let countdownInterval
let alarmTimeout;

function setAlarm() {
const secondsInput = document.getElementById("alarmSet").value;
const totalSeconds = parseInt(secondsInput, 10);

if (isNaN(totalSeconds) || totalSeconds <= 0) {
alert("Please enter a valid number of seconds.");
return;
}

// Clear any existing countdown
clearInterval(countdownInterval);
clearTimeout(alarmTimeout);

const alarmDuration = totalSeconds * 1000;
const endTime = Date.now() + alarmDuration;

// set alarm
alarmTimeout = setTimeout(() => {
playAlarm();
}, alarmDuration);

// Update countdown
const updateCountdown = () => {
const timeLeft = endTime - Date.now();
Comment on lines +26 to +27
Copy link
Member

@illicitonion illicitonion Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is still inconsistently indented compared to the rest of the file


if (timeLeft <= 0) {
clearInterval(countdownInterval);
document.getElementById("timeRemaining").innerText = "Time Remaining: 00:00";
return;
}

const minutes = Math.floor((timeLeft / 1000) / 60);
const seconds = Math.floor((timeLeft / 1000) % 60);

document.getElementById("timeRemaining").innerText =
`Time Remaining: ${String(minutes).padStart(2, '0')}:${String(seconds).padStart(2, '0')}`;
};

//start countdown
updateCountdown();
countdownInterval = setInterval(updateCountdown, 1000);
}



// DO NOT EDIT BELOW HERE

Expand All @@ -23,3 +69,4 @@ function pauseAlarm() {
}

window.onload = setup;

4 changes: 2 additions & 2 deletions Sprint-3/alarmclock/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link rel="stylesheet" href="style.css" />
<title>Title here</title>
<title>Alarm Clock</title>
</head>
<body>
<div class="centre">
<h1 id="timeRemaining">Time Remaining: 00:00</h1>
<label for="alarmSet">Set time to:</label>
<input id="alarmSet" type="number" />
<input id="alarmSet" type="number" min= "1" placeholder="Second" required />
Copy link

@bp7968h bp7968h Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This input field looks good for normal people, how would a screen reader identify what to input, can this be improved for screen readers?


<button id="set" type="button">Set Alarm</button>
<button id="stop" type="button">Stop Alarm</button>
Expand Down