Sheffield | 25-ITP-SEP | Declan Williams | Sprint 2 | Data groups #845
Conversation
…onsole on new lines
… the first occurrence and rejoining the rest
… object and not an array
and check for matching key inside loop and return true if matches during iteration
…xisting properties
…ded test for non existent properties
CatchingKiyoko
added
📅 Sprint 2
Sprint-2/debug/recipe.js
Outdated
| console.log(`${recipe.title} serves ${recipe.serves} | ||
| ingredients: | ||
| ${recipe}`); | ||
| console.log(`${recipe.title}\n serves ${recipe.serves}\n ingredients:\n ${recipe.ingredients[0]}\n ${recipe.ingredients[1]}\n ${recipe.ingredients[2]}\n ${recipe.ingredients[3]}`); |
There was a problem hiding this comment.
Can you improve this statement by using Array.prototype.join() so that the code works for any number of ingredients?
There was a problem hiding this comment.
have implemented the change so this is cleaner and scales automatically no matter how many ingredients the array has.
Sprint-2/implement/contains.js
Outdated
| function contains() {} | ||
| function contains(obj, key) { | ||
| // check if "obj" is an object and not an array and we are working with plain objects | ||
| if (typeof obj !== "object" || Array.isArray(obj)) return false; |
There was a problem hiding this comment.
type of null is "object" too.
Sprint-2/implement/contains.js
Outdated
| for (let properties in obj){ | ||
|
|
||
| // check that if each of the properties names matches what were looking for in the key and return true if matches | ||
| if (properties === key) return true; | ||
| } |
There was a problem hiding this comment.
Can also consider using Object.hasOwn().
| // rejoin the rest incase there are "=" in the value | ||
| const value = rest.join("="); | ||
|
|
||
| queryParams[key] = value; |
There was a problem hiding this comment.
Please note that in real querystring, both key and value are percent-encoded or URL encoded in the URL. For example, the string "5%" will be encoded as "5%25". So to get the actual value of "5%25" (whether it is a key or value in the querystring), you should call a function to decode it.
May I suggest looking up any of these terms, and "How to decode URL encoded string in JS"?
There was a problem hiding this comment.
using decodeURIComponent() takes a URL encoded string and converts it back to the original characters so that it can make the key value pairs in a readable manner as they have special characters like "&, = and %" to not break the url format.
There was a problem hiding this comment.
This exercise is good for programming practice.
In practice, we could just use the built-in Class, URLSearchParams ,to parse query strings.
Sprint-2/implement/tally.js
Outdated
| } | ||
|
|
||
| // make an empty object to store items counted | ||
| const itemCount = {}; |
There was a problem hiding this comment.
Does the following function call returns the value you expect?
tally(["toString", "toString"]);
Suggestion: Look up an approach to create an empty object with no inherited properties.
cjyuan
added
Reviewed
… .join() instead of calling individually to work with any amount of ingredients
…ndentation and formatting and handles null safety
…for a cleaner object creation
CatchingKiyoko
added
Needs Review
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
All good. Keep up the good work.
| // rejoin the rest incase there are "=" in the value | ||
| const value = rest.join("="); | ||
|
|
||
| queryParams[key] = value; |
There was a problem hiding this comment.
This exercise is good for programming practice.
In practice, we could just use the built-in Class, URLSearchParams ,to parse query strings.
cjyuan
added
Complete
3 participants
Learners, PR Template
Self checklist
Changelist