Birmingham | ITP-Sep-2025 |Ahmad Ehsas | Sprint 3 | Alarm Clock #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

ahmadehsas wants to merge 6 commits into CodeYourFuture:main from ahmadehsas:feature/alarmclock

ahmadehsas commented Nov 19, 2025 •

edited

Loading

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

I have completed all the required tasks.

Questions

ahmadehsas added 4 commits

November 18, 2025 21:15


          Created the updateDisplay function to update the screen Time Remainin…

0aa234b

…g with minutes and seconds.


          Executed the setAlarm function that we can read the number the user t…

c0ed942

…yped, start a countdown from that number, update the display every second and play an alarm when the time reaches zero.


          Reset the alarm to make sure next time starts from the beginning and …

ec2a9ff

…clearing the interval stops the countdown immediately if user press Stop alarm.


          Made the background color change when the alarm clock finishes and re…

83bf7f8

…set the background color when Stop Alarm is pressed.

github-actions bot commented Nov 19, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

4 similar comments

github-actions bot commented Nov 19, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions bot commented Nov 19, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions bot commented Nov 19, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions bot commented Nov 19, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

ahmadehsas changed the title ~~Birmingham | ITP-Sep-Ahmad Ehsas | sprint 3 | Data groups | Feature/alarmclock~~ Birmingham | ITP-Sep-2025 |Ahmad Ehsas | sprint 3 | Feature/alarmclock

github-actions bot commented Nov 19, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

ahmadehsas changed the title ~~Birmingham | ITP-Sep-2025 |Ahmad Ehsas | sprint 3 | Feature/alarmclock~~ Birmingham | ITP-Sep-2025 |Ahmad Ehsas | sprint 3 | Alarm Clock

github-actions bot commented Nov 19, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

1 similar comment

github-actions bot commented Nov 19, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

ahmadehsas added the Needs Review label

github-actions bot commented Nov 19, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions bot removed the Needs Review label

github-actions bot commented Nov 19, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

ahmadehsas changed the title ~~Birmingham | ITP-Sep-2025 |Ahmad Ehsas | sprint 3 | Alarm Clock~~ Birmingham | ITP-Sep-2025 |Ahmad Ehsas | Data groups | Alarm Clock

github-actions bot commented Nov 19, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

ahmadehsas added the Needs Review label

github-actions bot commented Nov 19, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Sprint part (Data groups) doesn't match expected format (example: 'Sprint 2', without quotes)

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions bot removed the Needs Review label

ahmadehsas changed the title ~~Birmingham | ITP-Sep-2025 |Ahmad Ehsas | Data groups | Alarm Clock~~ Birmingham | ITP-Sep-2025 |Ahmad Ehsas | Sprint 3 | Alarm Clock

github-actions bot commented Nov 19, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

2 similar comments

github-actions bot commented Nov 19, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions bot commented Nov 19, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

ahmadehsas added the Needs Review label

jaymes15 suggested changes

View reviewed changes

Sprint-3/alarmclock/alarmclock.js Outdated

+                // validate the input value
+                if (!Number.isFinite(timeLeft) || timeLeft <= 0) {  // The Number.isFinite() method is a way to test whether a value
+                // is a finite number value. and also prevents the error if the user types nothing or a negative number.
+                  return "input is invalid"; //  input is invalid

jaymes15 Nov 22, 2025

Nice Work @ahmadehsas
The value returned here input is invalid
is it been used anywhere in the code?

if it is not been been used we can just use return without input is invalid

Sprint-3/alarmclock/alarmclock.js Outdated



		}
		let countdown = null;

jaymes15 Nov 22, 2025

@ahmadehsas I think it would be more readable to move let countdown = null above setAlarm()

Sprint-3/alarmclock/alarmclock.js

+                audio.currentTime = 0; // reset to start, make sure next time play alarm starts from the beginning.
+                // reset the background color to original
+                document.body.style.backgroundColor = "";

jaymes15 Nov 22, 2025

This is good!
I noticed we are only resetting the background color when we pause the alarm but we do not reset the background when setting new alarm in setAlarm

Sprint-3/alarmclock/alarmclock.js

+                    playAlarm(); // play the alarm sound
+                    // change background color when the alarm clock finishes
+                    document.body.style.backgroundColor = "red";

jaymes15 Nov 22, 2025

What happens when the user lets the alarm finish (without clicking stop), the background stays red forever.
I think you should reset he background color before starting a new alarm, inside setAlarm()

jaymes15 removed the Needs Review label

jaymes15 added 📅 Sprint 3 Reviewed labels

ahmadehsas added 2 commits

November 23, 2025 00:23


          removed 'input is invalid' from the return on line 9 and moved the le…

b094924

…t countdown = null; above the setAlarm for better readable.


          When the set Alarm button is clicked, the backround color reset to it…

3d400c6

…s original color.

ahmadehsas added Needs Review and removed Reviewed labels

jaymes15 approved these changes

View reviewed changes

jaymes15 left a comment

Good Job!! @ahmadehsas

jaymes15 self-requested a review

November 23, 2025 05:28

jaymes15 added Complete and removed Needs Review labels

jaymes15 approved these changes

View reviewed changes

ahmadehsas mentioned this pull request

Birmingham | Data groups | Ahmad Ehsas ahmadehsas/My-Coursework-Planner#85

Open

illicitonion closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete 📅 Sprint 3