West Midlands | 25 Sep ITP | Iswat Bello | Sprint 3 | Build quote generator app #868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the heading to "Quote Generator"
…th the test cases
…e random quote rendering
…/Module-Data-Groups into >feature/quote_generator
Iswanna
added
🏕 Priority Mandatory
…async click test failures
Downgraded @testing-library/user-event from v14 to v13.5.0 because version 14 introduces asynchronous userEvent handlers, causing the existing synchronous Jest tests to fail. Version 13 matches the behaviour the tests were originally written for, allowing all tests to pass again.
jaymes15
reviewed
Nov 22, 2025
|
|
||
| // call pickFromArray with the quotes array to check you get a random quote | ||
| // Function to display a random quote on the page | ||
| function displayRandomQuote() { |
There was a problem hiding this comment.
Good job keeping displayRandomQuote() focused on a single responsibility — fetching a quote and updating the DOM. This helps keep the logic readable and easy to maintain.
jaymes15
reviewed
Nov 22, 2025
| } | ||
|
|
||
| // Add a click event listener to the "New quote" button | ||
| document.getElementById("new-quote").addEventListener("click", () => { |
There was a problem hiding this comment.
This is good! but we can make it cleaner by using a named function.
for example:
document.getElementById("new-quote").addEventListener("click", displayRandomQuote);
jaymes15
approved these changes
Nov 22, 2025
jaymes15
left a comment
jaymes15
left a comment
There was a problem hiding this comment.
Nice work — your solution is clean and readable
jaymes15
added
Complete
Author
Thank you so much for the feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
In this pull request, I completed the quote generator project by implementing the random quote functionality. The app now displays a random quote and its author when the page loads.
Questions
Hi. Please could you review my PR? I’d really appreciate your feedback.