Skip to content

Birmingham | ITP-Sep-2025 | Ahmad Ehsas | Sprint 3 | Feature/quotegenerator #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ahmadehsas wants to merge 8 commits into from
Closed

Birmingham | ITP-Sep-2025 | Ahmad Ehsas | Sprint 3 | Feature/quotegenerator #869

ahmadehsas wants to merge 8 commits into from

Conversation

@ahmadehsas
Copy link

@ahmadehsas ahmadehsas commented Nov 21, 2025 •
edited
Loading

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I have completed all the required tasks.

Questions

@ahmadehsas
Created the updateDisplay function to update the screen Time Remainin…
0aa234b 
…g with minutes and seconds.
@ahmadehsas
Executed the setAlarm function that we can read the number the user t…
c0ed942 
…yped, start a countdown from that number, update the display every second and play an alarm when the time reaches zero.
@ahmadehsas
Reset the alarm to make sure next time starts from the beginning and …
ec2a9ff 
…clearing the interval stops the countdown immediately if user press Stop alarm.
@ahmadehsas
Made the background color change when the alarm clock finishes and re…
83bf7f8 
…set the background color when Stop Alarm is pressed.
@ahmadehsas
Selected a Title and access to the HTML elements using getElementById.
fad040d
@ahmadehsas
Created a function to display a random quote.
2999e89
@ahmadehsas
Changed the background color.
a5c1c4a
@ahmadehsas
Style the quote, author's text, button to dark mode, and button hover…
173758f 
… effect.
@github-actions
Copy link

github-actions bot commented Nov 21, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

1 similar comment
@github-actions
Copy link

github-actions bot commented Nov 21, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@ahmadehsas ahmadehsas added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. 📅 Sprint 3 Assigned during Sprint 3 of this module labels Nov 21, 2025
bp7968h
bp7968h reviewed Nov 22, 2025
View reviewed changes
Copy link

@bp7968h bp7968h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complete

@bp7968h bp7968h added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 24, 2025
@ahmadehsas ahmadehsas mentioned this pull request Nov 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bp7968h bp7968h bp7968h left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Data-Groups The name of the module. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ahmadehsas @bp7968h @illicitonion