Birmingham | 25-ITP-Sep | Joy Opachavalit | Sprint 3 | Alarm clock app #875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enjoy15
added
📅 Sprint 3
jaymes15
added
Review in progress
jaymes15
suggested changes
Nov 22, 2025
Sprint-3/alarmclock/alarmclock.js
Outdated
| let intervalId = null; | ||
|
|
||
| function format(seconds) { | ||
| const m = String(Math.floor(seconds / 60)).padStart(2, "0"); |
There was a problem hiding this comment.
@enjoy15 We can make this variable name more descriptive
Author
There was a problem hiding this comment.
variable name changed to minute
Sprint-3/alarmclock/alarmclock.js
Outdated
|
|
||
| function format(seconds) { | ||
| const m = String(Math.floor(seconds / 60)).padStart(2, "0"); | ||
| const s = String(seconds % 60).padStart(2, "0"); |
There was a problem hiding this comment.
@enjoy15 We can make this variable name more descriptive
Author
There was a problem hiding this comment.
variable name changed to second
| heading.textContent = `Time Remaining: ${format(remaining)}`; | ||
| } | ||
|
|
||
| function tick() { |
|
|
||
| function setAlarm() { | ||
| const value = parseInt(input.value, 10); | ||
| if (!Number.isFinite(value) || value <= 0) return; |
There was a problem hiding this comment.
Nice validation! @enjoy15
However, it would help readability to add a short comment explaining what this guard clause does.
jaymes15
added
Reviewed
enjoy15
added
the
Needs Review
jaymes15
approved these changes
Nov 23, 2025
jaymes15
approved these changes
Nov 23, 2025
jaymes15
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
-Completed alram clock app