West Midlands | 25-ITP-Sept | Baba Yusuf | Sprint 3 | Alarm Clock #891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baba05206
added
📅 Sprint 3
cjyuan
reviewed
Nov 29, 2025
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Can you also keep this branch clean?
Comment on lines
+11
to
+14
| function format(num) { | ||
| if (num < 10) return "0" + num; | ||
| return num; | ||
| } |
Contributor
There was a problem hiding this comment.
Why not just use String.prototype.padStart()?
Comment on lines
+32
to
+36
| heading.innerText = | ||
| "Time Remaining: " + | ||
| format(Math.floor(time / 60)) + | ||
| ":" + | ||
| format(time % 60); |
Contributor
There was a problem hiding this comment.
This code is identical to those on lines 16-20 -- a hint that indicates we could simplify the code.
|
|
||
| const heading = document.getElementById("timeRemaining"); | ||
|
|
||
| clearInterval(intervalId); |
Contributor
There was a problem hiding this comment.
In addition to clearing intervalId, can you think of anything else that should also be reset before a new countdown starts?
|
|
||
| function setAlarm() { | ||
| const input = document.getElementById("alarmSet"); | ||
| let time = Number(input.value); |
Contributor
There was a problem hiding this comment.
Can you think of any potential invalid input that you should prevent?
cjyuan
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I implemented the setAlarm() function as per instruction
Checked for update to the testing framework by running npm install
Updated the title in the index.html file as per task instruction
Questions