Glasgow | Jan-26 | Abraham Habte | Sprint 2 | form control #1016
+50
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l as placeholders
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Abrsh100
added
the
Needs Review
LonMcGregor
reviewed
Jan 28, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on this task, I've left some comments with pointers
| <span>Customer Name: </span> | ||
| <strong><span aria-label="required">*</span></strong> | ||
| </label> | ||
| <input type="text" id="name" name="customer-name" required pattern="[A-Za-z\s\.]+" minlength="2" maxlength="40"/> |
There was a problem hiding this comment.
Some people have very long names,how would your application react to this?
| <span>Email: </span> | ||
| <strong><span aria-label="required">*</span></strong> | ||
| </label> | ||
| <input type="email" id="email" name="customer-mail" required minlength="5" maxlength="50" placeholder="example@gmail.com" /> |
There was a problem hiding this comment.
same comment as for the names, if they have a very long email, would they still be able to use your app?
| <span>Color:</span> | ||
| <strong><span aria-label="required">*</span></strong> | ||
| </label> | ||
| <select id="color preference" name="color preference"> |
There was a problem hiding this comment.
You offer one of the options pre-selected here. What do you think would happen if someone pressed the "enter" key thinking it would take them through the form to make choices?
LonMcGregor
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
creatining all the requerd form with requirment and placeholders
Questions
No Questions