London | 26-ITP-Jan | Damian Dunkley | Sprint 1 | Feature/Wireframe

[DamianDL]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

New PR to effect changes to Wireframe;

1. removed old up branch,
2. removed old Index file
3. updated CSS to centre initial header.
   Will close initial request London | 26-ITP-Jan | Damian Dunkley | Sprint 1 | Feature/Wireframe #958

Questions

Am I correct to remove the image and just have the text boxes?

[netlify]

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	124fb10
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/697a2bad0f088900082b378a
😎 Deploy Preview	https://deploy-preview-1019--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[jenny-alexander]

@DamianDL - your webpage is almost complete. There are few more changes to make in order for it to meet exercise requirements though.

Your alt text for the 3 images has a small mistake in it.
There should be opening quotes (") at the beginning of the alt text and closing quotes (") at the end of it.
Here is an example: <img src="dog.jpg" alt="Golden retriever puppy playing with a tennis ball">

[jenny-alexander]

Instead of saying that your webpage is a draft of the page, can you think of a sentence that summarizes your webpage?

[jenny-alexander]

Can you think of any useful information you can add to your footer instead of the default text?
Other trainees have included:

• name
• link to CYF socials
• your email

Any of these 👆 will be an improvement to the default text. 🙂

[DamianDL]

Thanks Jenny, updates to initial page description, alt text for three pictures and Footer. Thanks for reviewing yesterday.

[jenny-alexander]

Can you check the 'What is the purpose of a wireframe' image? Currently it shows a broken link.

[DamianDL]

Please review?

1. Wireframe image updated
2. Page description updated, details added and "draft" removed.
3. Footer updated with my name and reference to Course.
   Thanks

[jenny-alexander]

Please review?

1. Wireframe image updated
2. Page description updated, details added and "draft" removed.
3. Footer updated with my name and reference to Course.
   Thanks

@DamianDL Your changes look great! The only thing left to modify is your footer.

• I can't read the text when I start to scroll down the page.
• Ensure that the footer spans across the entire width of the page (or close to it).

[DamianDL]

Thanks Jenny,
Changes made to CSS to format the footer, with background the same as the rest of the page and fix to the bottom of the page.

[jenny-alexander]

Thanks Jenny, Changes made to CSS to format the footer, with background the same as the rest of the page and fix to the bottom of the page.

Can you check the footer again? It is no longer fixed in place.

[jenny-alexander]

Hi @DamianDL - I don't see your footer as fixed, can you check again?
The footer should be visible at all times when viewing your webpage.

This resource might be helpful: https://www.w3schools.com/howto/howto_css_fixed_footer.asp

[DamianDL]

Thanks Jenny, changes made to make footer bottom of viewport and to change background colour and font default. Thanks

[jenny-alexander]

Approved ✅ Good job!
💡 Tip for future -> It looks more professional if the footer spans the entire width of the page. You can add this to the footer class in CSS:

width: 100%;