Manchester | 26-ITP-Jan | Abdu Mussa | Sprint 2 | Form-Controls #1026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with validity requirement, used radio input type for the colour and size, used break for the list for accessibility, used fieldset for list of same types
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Abduhasen
changed the title
Abduhasen
added
the
Needs Review
Abduhasen
added
📅 Sprint 2
Form-Controls/index.html
Outdated
| <p> | ||
| <div> | ||
| <label for="name">NAME *</label> <!--write customer's name input--> | ||
| <input type="text" name="name" id="name" minlength="2" maxlength="20" required> |
There was a problem hiding this comment.
can you think of a better way to determine what a valid name is
Author
There was a problem hiding this comment.
I researched more and I came up with some update but am not sure it is good enough.
Form-Controls/index.html
Outdated
| <p> | ||
| <div> | ||
| <label for="email">Email *</label> <!-- customer's email --> | ||
| <input type="email" name="email" id="email" required> |
There was a problem hiding this comment.
Also think of or research for a better way to determine what a valid email is
Author
There was a problem hiding this comment.
i did some update but am not sure it is well or not
A-O-Emmanuel
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manchester | 26-ITP-Jan | Abdu Mussa | Sprint 2 | Form-Controls
##Learners, PR Template
##Self checklist
##Changelist
1.added name and email label and input
2.added list for colour and size with label and radio input
3.categorised the list with two different part of fieldset
4.added submit button
A form using html form and created semantic elements and added labels with list and name and email with input elements, checked the form with lighthouse it's accessibility, created fieldset and legend to manage different part of the form with there similarity.
##Questions
N/A