Skip to content

Conversation

@mshayriyesaricicek
Copy link

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I have added articles with images and links to my wireframe.

@netlify
Copy link

netlify bot commented Jan 24, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 066c2a7
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/697f5c29741ccf000847665d
😎 Deploy Preview https://deploy-preview-1052--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 5 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@cjyuan
Copy link
Contributor

cjyuan commented Jan 30, 2026

Your webpage could not be deployed on Netlify properly, and I think the failure is related to the image file size. Can you try removing the three JPEG images from your repo and just use the placeholder.svg in the HTML file?

Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1

When a wireframe is provided, our implementation should closely reflect its appearance and layout to ensure consistency with design expectations. You're off to a solid start, but the main purpose of implementing a wireframe is to translate structure and functionality, not final visual design. Visual design is usually handled by UI/graphic designers after the wireframe phase. To better align with the wireframe, here are a few areas where the layout and appearance could be refined:

  • Your page does not have a subtitle (in the wireframe image, under the "PAGE TITLE" there is a "A SHORT DESCRIPTION" subtitle)
  • In the wireframe image, the title, text content, and the READ MORE link of the first article are left aligned instead of centered.
  • In the wireframe image, all articles have a visible border.

2

One of the acceptance criteria, "The page footer is fixed to the bottom of the viewport", has not yet been satisfied. Can you make the necessary change? (Suggestion: Ask an AI tool what that requirement means).

@cjyuan cjyuan added the Reviewed Volunteer to add when completing a review with trainee action still to take. label Jan 30, 2026
@mshayriyesaricicek mshayriyesaricicek added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 1, 2026
@cjyuan
Copy link
Contributor

cjyuan commented Feb 1, 2026

Can you also address the comments I left two days ago? One is about refining the layout to better align with the wireframe. The second one is about fixing the footer on the viewport (to meet one of the requirements).

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants