Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 59 additions & 25 deletions Form-Controls/index.html
Original file line number Diff line number Diff line change
@@ -1,27 +1,61 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<title>My form exercise</title>
<meta name="description" content="" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
</head>
<body>
<header>
<h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
</form>
</main>
<footer>
<!-- change to your name-->
<h2>By HOMEWORK SOLUTION</h2>
</footer>
</body>
</html>

<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Product Form</title>
<link rel="stylesheet" href="style.css" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done for the good Job. You have also included accessibility thats very good. Please keep it up. However, your styles.css may be missing or using the wrong reference. Please check this

</head>

<body>
<header>
<h1>Product Pick</h1>
</header>

<main>
<form aria-label="Product selection form">
<div>
<label for="name">Name</label>
<input minlength="2" placeholder="name surname" id="name" type="text" name="Name" required
aria-required="true" />
</div>

<div>
<label for="email">E-mail</label>
<input type="email" name="E-mail" id="email" placeholder="name@example.com" required aria-required="true" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to use the minlength for additional validation for email?

</div>

<div>
<label for="colour">Colour</label>
<select name="colour" id="colour" required aria-required="true" aria-label="Select a colour">
<option value="">Select a colour</option>
<option value="Green">Green</option>
<option value="Yellow">Yellow</option>
<option value="Purple">Purple</option>
</select>
</div>

<div>
<label for="size">Size</label>
<select name="size" id="size" required aria-required="true" aria-label="Select a size">
<option value="">Select a size</option>
<option value="xs">Xs</option>
<option value="s">S</option>
<option value="m">M</option>
<option value="l">L</option>
<option value="xl">XL</option>
<option value="xxl">XXL</option>
</select>
</div>

<button type="submit">Submit</button>
</form>
</main>

<footer>
<h2>Merve Reis</h2>
</footer>
</body>

</html>