Skip to content

London | JAN-26 | Divine Mankrado | Sprint 2 | Form Control #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
divinmank wants to merge 33 commits into
base: main
Choose a base branch
from
Open

London | JAN-26 | Divine Mankrado | Sprint 2 | Form Control #1091

divinmank wants to merge 33 commits into from

Conversation

@divinmank
Copy link

@divinmank divinmank commented Jan 29, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

My code asks the user their name and email which has to be text only. Then it gives them one choice between the options red, green and blue to select their T-shirt color. It then gives a dropdown selection for what size to pick.

@divinmank
I changed the header for the body
c004307
@divinmank
Finished the content for article 2 and 3
6529e71
@divinmank
Added a hash instead of a link in html
c51d6cc
@divinmank
I added images to the background.
91de83b
@divinmank
Corrected CSS
cd44d17
@divinmank
Corrected image address
23b9781
@divinmank
Changed text to white
fdfaf6d
@divinmank
Changed text to white
04fa1ee
@divinmank
Text change to white
038d24e
@divinmank
Fixed background
baef6b3
@divinmank
Created the Input fields and added a submit button.
bae3ed5
@divinmank
Created the Input fields and added a submit button.
888b0ed
@divinmank
Made another html page for the GET action and have added ids and labe…
eb3da85 
…ls to the input
@divinmank
Added checkboxes
b31f408
@divinmank
Added checkbox for sizes
f56e156
@divinmank
Added placeholders for the other options
f76d6f4
@divinmank
Changed attribtue type from checkbox to radio to allow for only one s…
af18453 
…election
@divinmank
Corrected mistake with radio types
1ac8d59
@divinmank
Fixed mistake with two inputs for one prompt
0037049
@divinmank
fixed accessibility
366151a
@divinmank
cleaned up email and name
7b7f3f1
@divinmank
cleaned up code
e667bbd
@divinmank
Collaborated and updated code to get good scores on lighthouse
d1711be
@netlify
Copy link

netlify bot commented Jan 29, 2026 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 7de9d48
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/697ca32e43d92700084f8bfe
😎 Deploy Preview https://deploy-preview-1091--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (🔴 down 4 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

Sign in to view
@divinmank divinmank changed the title London | 26-ITP-January | Divine Mankrado | Sprint 2 | Product Pick London | 26-January | Divine Mankrado | Sprint 2 | Product Pick Jan 29, 2026
@github-actions

This comment has been minimized.

Sign in to view
@divinmank divinmank changed the title London | 26-January | Divine Mankrado | Sprint 2 | Product Pick London | JAN-26 | Divine Mankrado | Sprint 2 | Form Control Jan 29, 2026
@github-actions

This comment has been minimized.

Sign in to view
@divinmank divinmank added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 30, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 30, 2026
@divinmank divinmank added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 30, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 30, 2026
@divinmank divinmank added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 30, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 30, 2026
@divinmank divinmank added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 30, 2026
@divinmank divinmank mentioned this pull request Jan 30, 2026
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@divinmank