Skip to content

Conversation

@Pretty548
Copy link

@Pretty548 Pretty548 commented Jan 30, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Used semantic HTML (header, main, section, article, footer)
  • Added page header with title and description
  • Created three articles with title, summary, and link
  • Added content explaining README, wireframes, and Git branches
  • Styled the page using an external CSS file
  • Fixed the footer to the bottom of the viewport
  • Matched layout to the provided wireframe
  • Achieved 100 Accessibility score in Lighthouse
  • Committed and pushed changes to feature/wireframe branch

Questions

How does using semantic HTML improve accessibility and the overall structure of a webpage?

@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@netlify
Copy link

netlify bot commented Jan 30, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 1d0770b
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/697ccb4853e84e00086ba816
😎 Deploy Preview https://deploy-preview-1096--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 95 (🟢 up 9 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

2 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@Pretty548 Pretty548 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 30, 2026
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Page and code look good.

One of the acceptance criteria, "The page footer is fixed to the bottom of the viewport", has not yet been satisfied. Can you make the necessary change? (Suggestion: Ask ChatGPT what that requirement means).

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants