London| Sep 25 ITP| Daniel Solomon|Sprint 1| Wireframe by danisoloo · Pull Request #827 · CodeYourFuture/Module-Onboarding

danisoloo · 2025-09-19T18:59:34Z

London | 26-ITP-Jan| Daniel Solomon | Sprint 1 | Wireframe

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

I have restored the index.html file in the main folder and placed the wireframe code in the relevant file within the wireframe folder.

I have improved lighthouse score to 100

netlify · 2025-09-19T18:59:38Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`5335c5e`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/68d94969f3eb7b0008319ca1
😎 Deploy Preview	https://deploy-preview-827--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 91 (🟢 up 5 from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

github-actions · 2025-09-19T18:59:58Z

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-09-19T19:05:21Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

github-actions · 2025-09-19T19:14:57Z

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

Mahtem · 2025-09-20T12:34:15Z

please put your title as as below, you have missed "Sprint 1" in your title.

London| Sep 25 ITP| Daniel Solomon|Sprint 1| Wireframe

and delete the default "Brief Explain" and "Add question" if you do not have any question in order to pass the validation.

Basically do it according to the PR template provided in the folder.

github-actions · 2025-09-20T13:14:19Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

danisoloo · 2025-09-20T13:28:40Z

I’ve done like that but it says failed

…

On Saturday, September 20, 2025, Mahtem ***@***.***> wrote: *Mahtem* left a comment (CodeYourFuture/Module-Onboarding#827) <#827 (comment)> please put your title as as below, you have missed "Sprint 1" in your title. London| Sep 25 ITP| Daniel Solomon|Sprint 1| Wireframe and delete the default "Brief Explain" and "Add question" if you do not have any question in order to pass the validation. Basically do it according to the PR template provided in the folder. — Reply to this email directly, view it on GitHub <#827 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BTQPWO6UZ4C5I6PRJV4INW33TVCVZAVCNFSM6AAAAACG73FSGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGMJUHE2DINBUHE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

cjyuan

It seems you have modified the wrong index.html.
You were supposed to modify the index.html inside the Wireframe folder.
Can you also restore the original index.html in the top-level folder (to keep your branch clean)?
Your placeholder images do not seem to work. You can use the placeholder.svg that's already in the Wireframe folder in this exercise.
In the PR description, can you restore the "Changelist" section and add a brief description about the changes you made in your PR?

danisoloo · 2025-09-27T14:56:34Z

ok what about my form control?

…

On Sat, Sep 27, 2025 at 10:42 AM CJ Yuan ***@***.***> wrote: ***@***.**** commented on this pull request. 1. It seems you have modified the wrong index.html. You were supposed to modify the index.html inside the Wireframe folder. 2. Your placeholder images do not seem to work. You can use the placeholder.svg that's already in the Wireframe folder in this exercise. 3. In the PR description, can you restore the "Changelist" section and add a brief description about the changes you made in your PR? — Reply to this email directly, view it on GitHub <#827 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BTQPWO7432CCGRZS4F3SIQT3UZLZJAVCNFSM6AAAAACG73FSGWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTENZUG43DQNJTGA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

cjyuan

The images are not displayable.

In Markdown
The Changelist header in the PR description is not quite correctly formatted in Markdown.

## Header

Separated by space => a level-2 header

##Header

No space between ## an Header => treated as regular text

If there are more texts in the articles, the footer could block the text in the bottom two articles. Can you find a way to prevent the footer from obscuring the article content regardless of article length?

danisoloo · 2025-09-27T16:50:04Z

Can you check it again because it’s working for me when I load it

…

On Saturday, September 27, 2025, CJ Yuan ***@***.***> wrote: ***@***.**** commented on this pull request. 1. The images are not displayable. image.png (view on web) <https://github.com/user-attachments/assets/6e15c5bc-5e00-400b-84a6-1f08c10e9995> 2. In Markdown The Changelist header in the PR description is not quite correctly formatted in Markdown. ## Header Separated by space => a level-2 header ##Header No space between ## an Header => treated as regular text 3. If there are more texts in the articles, the footer could block the text in the bottom two articles. Can you find a way to prevent the footer from obscuring the article content regardless of article length? — Reply to this email directly, view it on GitHub <#827 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BTQPWO44JAEDMD37G7XEWFD3U2Z45AVCNFSM6AAAAACG73FSGWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTENZVGAYTAMJRGA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

cjyuan

Page looks good now.

Can you fix the "Changelist" heading in your PR description?

cjyuan · 2025-09-27T18:13:32Z

Wireframe/index.html

+        <article>
+          <img src="https://media.istockphoto.com/id/876487150/photo/abstract-background-of-source-code-branch-3d-rendering.jpg?b=1&s=612x612&w=0&k=20&c=P5xSmni20OHy5EqfydTFwiCCN_xRzAOGToUKXAPqZ_o=" alt="Git branching diagram">
+          <h2>What is a branch in Git?</h2>
+          <p>A branch in Git is a separate line of development that allows you to work on new features or bug fixes without affecting the main codebase. Once changes are ready, branches can be merged back into the main branch.</p>


Suggestion (Optional change)

Line 35 can be better formatted as:

<p> A branch in Git is a separate line of development that allows you to work on new features or bug fixes without affecting the main codebase. Once changes are ready, branches can be merged back into the main branch. </p>

To understand why, you can ask ChatGPT these questions:

How HTML treat mutliple whitespace characters in text?

What's the advantage of not writing a long paragraph of text in a single line in HTML?

VSCode's "Format Document" feature can help us format our code for better readability and consistency, including breaking a long line of text into shorter lines of text.
To use the feature, right-click inside the code editor and select the option.

cjyuan · 2025-09-28T02:54:37Z

You can try these in future PRs.

Whenever you have addressed the reviewer's feedback (even if the request does not involve changing any code), you should change the label to "Needs review" to indicate the changes are ready to be reviewed.
The "Changelist" in the PR description is for describing what this PR is about (instead of what you have changed in respond to the reviewer's comment). To learn more about pull request, you can try asking ChatGPT what a PR is, and what do developers usually write in the Changelist section in the PR description?

danisoloo · 2025-09-28T04:04:35Z

Yes, but I’m using my Phone and I didn't get the label, I’m figuring it out.

…

On Sunday, September 28, 2025, CJ Yuan ***@***.***> wrote: *cjyuan* left a comment (CodeYourFuture/Module-Onboarding#827) <#827 (comment)> You can try these in future PRs. 1. Whenever you have addressed the reviewer's feedback (even if the request does not involve changing any code), you should change the label to "Needs review" to indicate the changes are ready to be reviewed. 2. The "Changelist" in the PR description is for describing what this PR is about (instead of what you have changed in respond to the reviewer's comment). To learn more about pull request, you can try asking ChatGPT what a PR is, and what do developers usually write in the Changelist section in the PR description? — Reply to this email directly, view it on GitHub <#827 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BTQPWO2TZ4YA763ZISTG4VL3U5EYFAVCNFSM6AAAAACG73FSGWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGNBSGIYTONRRGU> . You are receiving this because you authored the thread.Message ID: ***@***.***>

cjyuan · 2025-09-28T05:18:24Z

Have you filled in the form in this backlog (in Sprint 1)?

If so, have you clicked the link in an email join the CodeYourFuture group on GitHub (so that you can use labels on your PRs)?
The invitation email is sent by GitHub. You can search "Invite" in your email account to locate the email.

cjyuan · 2025-09-29T01:41:11Z

Changes look good. Well done!

danisoloo · 2025-09-29T07:19:39Z

Thanks for guiding me through this, what’s the next step I have to do? Both my sprint are well now right ?

cjyuan · 2025-09-29T12:45:38Z

In addition to applying for trainee, you also need to submit an issue in Step 1 on the Course Platform. See the "Success" page of Module Onboarding about what you need to submit.

danisoloo · 2025-09-29T17:26:23Z

I have created new issue and submitted it in step 1 on the course platform. Thanks a lot.

…

Message ID: ***@***.*** com>

Dani_test_pr

3bf12fd

danisoloo changed the title ~~Dani_test_pr~~ London| Sep 25 ITP| Daniel Solomon| Wireframe Sep 19, 2025

danisoloo added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 20, 2025

cjyuan reviewed Sep 27, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 27, 2025

danisoloo added 3 commits September 27, 2025 16:36

Update index.html in wireframe folder

77f3d3d

restored index.html in module folder

cc044e5

replaced placeholder with placeholder svg in image tag

d0fdbc3

cjyuan reviewed Sep 27, 2025

View reviewed changes

danisoloo added 3 commits September 27, 2025 17:16

updated images and added alt attributes

6d30555

changed readme img

d4f2065

Updated image source

b1ab304

danisoloo added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Sep 27, 2025

cjyuan reviewed Sep 27, 2025

View reviewed changes

danisoloo added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 1 Assigned during Sprint 1 of this module and removed Complete Volunteer to add when work is complete and all review comments have been addressed. labels Sep 28, 2025

danisoloo added 3 commits September 28, 2025 14:29

enforced a stricter validation

d1f7518

Updated line 35

9e6fbc7

Improved lighthouse to 100

5335c5e

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 29, 2025

danisoloo mentioned this pull request Sep 29, 2025

Sep_25_ITP | Onboarding | Daniel_Solomon danisoloo/My-Coursework-Planner#45

Open

illicitonion closed this Jan 7, 2026

danisoloo added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 17, 2026

Uh oh!

Conversation

danisoloo commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelist

Uh oh!

netlify bot commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

github-actions bot commented Sep 19, 2025

Uh oh!

github-actions bot commented Sep 19, 2025

Uh oh!

github-actions bot commented Sep 19, 2025

Uh oh!

Mahtem commented Sep 20, 2025

Uh oh!

github-actions bot commented Sep 20, 2025

Uh oh!

danisoloo commented Sep 20, 2025 via email

Uh oh!

cjyuan left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

danisoloo commented Sep 27, 2025 via email

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

danisoloo commented Sep 27, 2025 via email

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Sep 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan commented Sep 28, 2025

Uh oh!

danisoloo commented Sep 28, 2025 via email

Uh oh!

cjyuan commented Sep 28, 2025

Uh oh!

cjyuan commented Sep 29, 2025

Uh oh!

danisoloo commented Sep 29, 2025

Uh oh!

cjyuan commented Sep 29, 2025

Uh oh!

danisoloo commented Sep 29, 2025 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

danisoloo commented Sep 19, 2025 •

edited

Loading

netlify bot commented Sep 19, 2025 •

edited

Loading

cjyuan left a comment •

edited

Loading

cjyuan Sep 27, 2025 •

edited

Loading