Manchester | ITP-Jan-26 | Joanne O'Malley | Sprint 1 | Wireframe#929
Open
joanne342 wants to merge 2 commits intoCodeYourFuture:mainfrom
Open
Manchester | ITP-Jan-26 | Joanne O'Malley | Sprint 1 | Wireframe#929joanne342 wants to merge 2 commits intoCodeYourFuture:mainfrom
joanne342 wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
joanne342
added
🏕 Priority Mandatory
Member
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
This is looking really good! I left a couple of questions, but they're both pretty minor things to think about :)
| text-align: left; | ||
| display: grid; | ||
| grid-template-columns: var(--space) 1fr var(--space); | ||
| grid-template-rows: auto 1fr auto; /* Add this */ |
Member
There was a problem hiding this comment.
What does your "Add this" comment here mean?
Same below with > a { align-self?
| voluptates. Quisquam, voluptates. | ||
| </p> | ||
| <a href="">Read more</a> | ||
| <img src="https://docs.github.com/assets/cb-2058/mw-1440/images/help/branches/pr-retargeting-diagram1.webp" alt="Branch image" /> |
Member
There was a problem hiding this comment.
Your alt text here isn't very descriptive. There isn't necessarily a great description of the visuals going on here (in which case you may want to use empty alt text to suggest to a screen reader "this image is decorative, it doesn't matter"), or you may want to try to think of a more descriptive alt text that would help someone who can't see the image.
illicitonion
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Edit the HTML and CSS so it looks like the wireframe image and briefly explain wireframes, branches and readmes including button links to additional info.
Questions
N/A