generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 409
London | 26-Jan-ITP | Angela McLeary | Sprint 1 | Wireframe to Web Code #986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AngelaMcLeary
wants to merge
16
commits into
CodeYourFuture:main
Choose a base branch
from
AngelaMcLeary:feature/wireframe
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
ae5b2f3
added 2 articles
AngelaMcLeary f052978
testing pink color for footer
AngelaMcLeary 81a422c
removed pink color on footer
AngelaMcLeary 96fce98
changed the heading to center and updated the text to Wireframe
AngelaMcLeary 114dfa9
Updated html with more content
AngelaMcLeary 9897acb
reset css and set body styling
AngelaMcLeary 16967ee
styled main attributes
AngelaMcLeary 56b3857
set out the grid for the content
AngelaMcLeary 91f5d9b
added contents container for text in article
AngelaMcLeary a46d999
layout fixed
AngelaMcLeary 3d7e9dd
added border to layout, formatting and added media querries
AngelaMcLeary 8398164
formatted code
AngelaMcLeary c462395
formatted code to make it readable
AngelaMcLeary 64c5bc4
updated readme file
AngelaMcLeary 7243e67
updated css code to variable
AngelaMcLeary 653c464
fixed the footer, It is now in the fixed position
AngelaMcLeary File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,62 @@ | ||
| <!DOCTYPE html> | ||
| <!doctype html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Wireframe</title> | ||
| <link rel="stylesheet" href="style.css" /> | ||
| </head> | ||
| <body> | ||
| <header> | ||
| <h1>Wireframe</h1> | ||
| <p> | ||
| This is the default, provided code and no changes have been made yet. | ||
| </p> | ||
| </header> | ||
| <main> | ||
| <article> | ||
| <img src="placeholder.svg" alt="" /> | ||
| <h2>Title</h2> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Wireframe | Process</title> | ||
| <link rel="stylesheet" href="style.css" /> | ||
| <link rel="preconnect" href="https://fonts.googleapis.com" /> | ||
| <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin /> | ||
| <link href="https://fonts.googleapis.com/css2?family=Roboto:ital,wght@0,100..900;1,100..900&display=swap" rel="stylesheet" /> | ||
| </head> | ||
| <body> | ||
| <header> | ||
| <h1>STARTING SIMPLE</h1> | ||
| <h2>Breaking down the development process</h2> | ||
| </header> | ||
|
|
||
| <main> | ||
| <article> | ||
| <img src="placeholder.svg" alt="A sample README file structure" /> | ||
| <div class="content"> | ||
| <h2>README.md</h2> | ||
| <p> | ||
| Lorem ipsum dolor sit amet consectetur adipisicing elit. Quisquam, | ||
| voluptates. Quisquam, voluptates. | ||
| The purpose of a README is to explain what the project is about. It | ||
| provides a summary of the project, the technology stack used, and | ||
| instructions for any required dependencies. | ||
| </p> | ||
| <a href="">Read more</a> | ||
| </article> | ||
| </main> | ||
| <footer> | ||
| <p> | ||
| This is the default, provided code and no changes have been made yet. | ||
| </p> | ||
| </footer> | ||
| </body> | ||
| </html> | ||
| <a href="https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-readmes">Read more</a> | ||
| </div> | ||
| </article> | ||
|
|
||
| <article> | ||
| <img src="placeholder.svg" alt="A simple website wireframe" /> | ||
| <div class="content"> | ||
| <h2>Wireframe</h2> | ||
| <p> | ||
| A wireframe is like a draft for your project. It shows where things | ||
| will go and how they work before you add colors, images, or final | ||
| design details. | ||
| </p> | ||
| <a href="https://www.productplan.com/glossary/wireframe/">Read more</a> | ||
| </div> | ||
| </article> | ||
|
|
||
| <article> | ||
| <img src="placeholder.svg" alt="Diagram of a Git branch" /> | ||
| <div class="content"> | ||
| <h2>A Branch in Git</h2> | ||
| <p> | ||
| A Git branch is a separate line of development within a repository. | ||
| It lets you work on features independently without affecting the main code. | ||
| </p> | ||
| <a href="https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-branches">Read more</a> | ||
| </div> | ||
| </article> | ||
| </main> | ||
|
|
||
| <footer> | ||
| <p>Wireframe | Sprint 1 | 2026</p> | ||
| </footer> | ||
| </body> | ||
| </html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,89 +1,118 @@ | ||
| /* Here are some starter styles | ||
| You can edit these or replace them entirely | ||
| It's showing you a common way to organise CSS | ||
| And includes solutions to common problems | ||
| As well as useful links to learn more */ | ||
|
|
||
| /* ====== Design Palette ====== | ||
| This is our "design palette". | ||
| It sets out the colours, fonts, styles etc to be used in this design | ||
| At work, a designer will give these to you based on the corporate brand, but while you are learning | ||
| You can design it yourself if you like | ||
| Inspect the starter design with Devtools | ||
| Click on the colour swatches to see what is happening | ||
| I've put some useful CSS you won't have learned yet | ||
| For you to explore and play with if you are interested | ||
| https://web.dev/articles/min-max-clamp | ||
| https://scrimba.com/learn-css-variables-c026 | ||
| ====== Design Palette ====== */ | ||
| :root { | ||
| --paper: oklch(7 0 0); | ||
| --ink: color-mix(in oklab, var(--color) 5%, black); | ||
| --font: 100%/1.5 system-ui; | ||
| --space: clamp(6px, 6px + 2vw, 15px); | ||
| --line: 1px solid; | ||
| --container: 1280px; | ||
| } | ||
| /* ====== Base Elements ====== | ||
| General rules for basic HTML elements in any context */ | ||
| --text-main: rgb(9, 9, 9); | ||
| --border-color: rgb(7, 7, 7); | ||
| --bg-body: rgb(245, 245, 245); | ||
| --bg-card: whitesmoke; | ||
| --bg-footer: rgb(238, 236, 233); | ||
| } | ||
|
|
||
| * { | ||
| padding: 0; | ||
| margin: 0; | ||
| box-sizing: border-box; | ||
| } | ||
|
|
||
| body { | ||
| background: var(--paper); | ||
| color: var(--ink); | ||
| font: var(--font); | ||
| background: var(--bg-body); | ||
| color: var(--text-main); | ||
| font-family: "Roboto", Helvetica, sans-serif; | ||
| } | ||
| a { | ||
| padding: var(--space); | ||
| border: var(--line); | ||
| max-width: fit-content; | ||
|
|
||
| header { | ||
| text-align: center; | ||
| padding: 2rem 1rem; | ||
| } | ||
| img, | ||
| svg { | ||
| width: 100%; | ||
| object-fit: cover; | ||
|
|
||
| h1 { | ||
| font-size: 3rem; | ||
| font-weight: 900; | ||
| margin-bottom: 0.5rem; | ||
| } | ||
| /* ====== Site Layout ====== | ||
| Setting the overall rules for page regions | ||
| https://www.w3.org/WAI/tutorials/page-structure/regions/ | ||
| */ | ||
| main { | ||
| max-width: var(--container); | ||
| margin: 0 auto calc(var(--space) * 4) auto; | ||
|
|
||
| h2 { | ||
| font-size: 1.7rem; | ||
| font-weight: 600; | ||
| } | ||
| footer { | ||
| position: fixed; | ||
| bottom: 0; | ||
|
|
||
| p { | ||
| line-height: 1.5; | ||
| } | ||
|
|
||
| a { | ||
| display: inline-block; | ||
| width: 140px; | ||
| text-decoration: none; | ||
| color: var(--text-main); | ||
| border: 1px solid var(--border-color); | ||
| padding: 10px 15px; | ||
| margin-top: 1.5rem; | ||
| text-align: center; | ||
| transition: all 0.2s ease; | ||
| } | ||
|
|
||
| a:hover, a:focus { | ||
| text-decoration: underline; | ||
| background-color: var(--text-main); | ||
| color: white; | ||
| outline: none; | ||
| } | ||
| /* ====== Articles Grid Layout ==== | ||
| Setting the rules for how articles are placed in the main element. | ||
| Inspect this in Devtools and click the "grid" button in the Elements view | ||
| Play with the options that come up. | ||
| https://developer.chrome.com/docs/devtools/css/grid | ||
| https://gridbyexample.com/learn/ | ||
| */ | ||
|
|
||
| main { | ||
| display: grid; | ||
| grid-template-columns: 1fr 1fr; | ||
| gap: var(--space); | ||
| > *:first-child { | ||
| grid-column: span 2; | ||
| } | ||
| grid-template-columns: repeat(2, 1fr); | ||
| gap: 1.5rem; | ||
| max-width: 1200px; | ||
| margin: 0 auto 4rem; | ||
| padding: 0 1rem; | ||
| } | ||
| /* ====== Article Layout ====== | ||
| Setting the rules for how elements are placed in the article. | ||
| Now laying out just the INSIDE of the repeated card/article design. | ||
| Keeping things orderly and separate is the key to good, simple CSS. | ||
| */ | ||
|
|
||
| main > article:first-child { | ||
| grid-column: 1 / -1; | ||
| } | ||
|
|
||
| article { | ||
| border: var(--line); | ||
| padding-bottom: var(--space); | ||
| text-align: left; | ||
| display: grid; | ||
| grid-template-columns: var(--space) 1fr var(--space); | ||
| > * { | ||
| grid-column: 2/3; | ||
| display: flex; | ||
| flex-direction: column; | ||
| background: var(--bg-card); | ||
| border: 1px solid var(--border-color); | ||
| } | ||
|
|
||
| article img { | ||
| display: block; | ||
| object-fit: cover; | ||
| width: 100%; | ||
| height: 250px; | ||
| border-bottom: 1px solid var(--border-color); | ||
| } | ||
|
|
||
| article .content { | ||
| display: flex; | ||
| flex-direction: column; | ||
| padding: 1.5rem; | ||
| flex-grow: 1; | ||
| } | ||
|
|
||
| article .content a { | ||
| margin-top: auto; | ||
| } | ||
|
|
||
| footer { | ||
|
|
||
| text-align: center; | ||
| padding: 0.8rem; | ||
| background-color: var(--bg-footer); | ||
| border-top: 1px solid #ddd; | ||
| position: fixed; | ||
| bottom: 0; | ||
| width: 100%; | ||
| } | ||
|
|
||
| @media (max-width: 768px) { | ||
| main { | ||
| grid-template-columns: 1fr; | ||
| } | ||
| > img { | ||
| grid-column: span 3; | ||
|
|
||
| h1 { | ||
| font-size: 2.2rem; | ||
| } | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice UI. The only thimg left is the footer not fixed to the bottom. On page load, it should be visible, before any scrolling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback, I can fix that. I'll do that straight away.