NW | 25-ITP_Sep | Ahmad Hmedan | Sprint 3 | implement and rewrite tests

Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

@@ -10,9 +10,18 @@
 function getAngleType(angle) {
   if (angle === 90) {
     return "Right angle";
+  } else if (angle < 90) {
+    return "Acute angle";
+  } else if (angle > 90 && angle < 180) {
+    return "Obtuse angle";
+  } else if (angle === 180) {
+    return "Straight angle";
+  } else {
+    return "Reflex angle";
   }
-   // Run the tests, work out what Case 2 is testing, and implement the required code here.
-   // Then keep going for the other cases, one at a time.
+
+  // Run the tests, work out what Case 2 is testing, and implement the required code here.
+  // Then keep going for the other cases, one at a time.
 }
 
 // The line below allows us to load the getAngleType function into tests in other files.
@@ -51,13 +60,17 @@ assertEquals(acute, "Acute angle");
 // Then the function should return "Obtuse angle"
 const obtuse = getAngleType(120);
 // ====> write your test here, and then add a line to pass the test in the function above
+assertEquals(obtuse, "Obtuse angle");
 
 // Case 4: Identify Straight Angles:
 // When the angle is exactly 180 degrees,
 // Then the function should return "Straight angle"
 // ====> write your test here, and then add a line to pass the test in the function above
-
+const straight = getAngleType(180);
+assertEquals(straight, "Straight angle");
 // Case 5: Identify Reflex Angles:
 // When the angle is greater than 180 degrees and less than 360 degrees,
 // Then the function should return "Reflex angle"
-// ====> write your test here, and then add a line to pass the test in the function above
+// ====> write your test here, and then add a line to pass the test in the function above
+const reflex = getAngleType(240);
+assertEquals(reflex, "Reflex angle");

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

@@ -5,11 +5,17 @@
 // Written here like this: 1/2 == Numerator/Denominator
 // the first test and first case is written for you
 // complete the rest of the tests and cases
-// write one test at a time, and make it pass, build your solution up methodically
+// write one test at a time, and make it pass, build your solution up
 
 function isProperFraction(numerator, denominator) {
+  if (denominator === 0) return false;
+  if (numerator < 1) numerator = Math.abs(numerator) ;
+  if (denominator < 1) denominator = Math.abs(denominator);
+
   if (numerator < denominator) {
     return true;
+  } else {
+    return false;
   }
 }
 
@@ -47,13 +53,20 @@ assertEquals(improperFraction, false);
 // Explanation: The fraction -4/7 is a proper fraction because the absolute value of the numerator (4) is less than the denominator (7). The function should return true.
 const negativeFraction = isProperFraction(-4, 7);
 // ====> complete with your assertion
+assertEquals(negativeFraction, true);
 
 // Equal Numerator and Denominator check:
 // Input: numerator = 3, denominator = 3
 // target output: false
 // Explanation: The fraction 3/3 is not a proper fraction because the numerator is equal to the denominator. The function should return false.
 const equalFraction = isProperFraction(3, 3);
 // ====> complete with your assertion
-
+assertEquals(equalFraction, false);
 // Stretch:
 // What other scenarios could you test for?
+//Negative fraction check
+//Input: numerator=-4, denominator=2;
+//target output: false
+// Explanation: The fraction -4/2 is not a proper fraction because the absolute value of the numerator (4) is more than the denominator (2). The function should return false.
+const negativeFractionCase2 = isProperFraction(-4, 2);
+assertEquals(negativeFractionCase2, false);

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

@@ -8,11 +8,19 @@
 // write one test at a time, and make it pass, build your solution up methodically
 // just make one change at a time -- don't rush -- programmers are deep and careful thinkers
 function getCardValue(card) {
+  const rank = card.slice(0, -1);
   if (rank === "A") {
     return 11;
   }
-}
+  if (rank === "J" || rank === "Q" || rank === "K") {
+    return 10;
+  }
 
+  const validRank = ["2", "3", "4", "5", "6", "7", "8", "9", "10"];
+  if (validRank.includes(rank)) {
+    return Number(rank);
+  } else return "Invalid card rank";
+}
 // The line below allows us to load the getCardValue function into tests in other files.
 // This will be useful in the "rewrite tests with jest" step.
 module.exports = getCardValue;
@@ -40,18 +48,26 @@ assertEquals(aceofSpades, 11);
 // Then it should return the numeric value corresponding to the rank (e.g., "5" should return 5).
 const fiveofHearts = getCardValue("5♥");
 // ====> write your test here, and then add a line to pass the test in the function above
-
+assertEquals(fiveofHearts, 5);
 // Handle Face Cards (J, Q, K):
 // Given a card with a rank of "10," "J," "Q," or "K",
 // When the function is called with such a card,
 // Then it should return the value 10, as these cards are worth 10 points each in blackjack.
-
+const jackofHearts = getCardValue("J♥");
+assertEquals(jackofHearts, 10);
+const queenofSpades = getCardValue("Q♠");
+assertEquals(queenofSpades, 10);
+const kingofSpades = getCardValue("K♠");
+assertEquals(kingofSpades, 10);
 // Handle Ace (A):
 // Given a card with a rank of "A",
 // When the function is called with an Ace,
 // Then it should, by default, assume the Ace is worth 11 points, which is a common rule in blackjack.
-
+const aceofHearts = getCardValue("A♥");
+assertEquals(aceofHearts, 11);
 // Handle Invalid Cards:
 // Given a card with an invalid rank (neither a number nor a recognized face card),
 // When the function is called with such a card,
 // Then it should throw an error indicating "Invalid card rank."
+const invalidCards = getCardValue("B♥");
+assertEquals(invalidCards, "Invalid card rank");

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js

@@ -12,15 +12,25 @@ test("should identify right angle (90°)", () => {
 // Case 2: Identify Acute Angles:
 // When the angle is less than 90 degrees,
 // Then the function should return "Acute angle"
+test("should identify Acute Angles", () => {
+  expect(getAngleType(70)).toEqual("Acute angle");
+});
 
 // Case 3: Identify Obtuse Angles:
 // When the angle is greater than 90 degrees and less than 180 degrees,
 // Then the function should return "Obtuse angle"
-
+test("should identify Obtuse Angles", () => {
+  expect(getAngleType(120)).toEqual("Obtuse angle");
+});
 // Case 4: Identify Straight Angles:
 // When the angle is exactly 180 degrees,
 // Then the function should return "Straight angle"
-
+test("should identify Straight Angles", () => {
+  expect(getAngleType(180)).toEqual("Straight angle");
+});
 // Case 5: Identify Reflex Angles:
 // When the angle is greater than 180 degrees and less than 360 degrees,
 // Then the function should return "Reflex angle"
+test("should identify Reflex Angles", () => {
+  expect(getAngleType(240)).toEqual("Reflex angle");
+});

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/2-is-proper-fraction.test.js

@@ -7,7 +7,25 @@ test("should return true for a proper fraction", () => {
 });
 
 // Case 2: Identify Improper Fractions:
-
+test("returns false for an improper fraction", () => {
+  expect(isProperFraction(5, 2)).toEqual(false);
+});
 // Case 3: Identify Negative Fractions:
-
+test("returns true for a negative proper fraction( absolute value of the numerator is less than the denominator)", () => {
+  expect(isProperFraction(-4, 7)).toEqual(true);
+});
 // Case 4: Identify Equal Numerator and Denominator:
+test("returns false when numerator equals denominator", () => {
+  expect(isProperFraction(9, 9)).toEqual(false);
+});
+
+test("return false when  numerator equals denominator when both are negative", () => {
+  expect(isProperFraction(-4, -4)).toEqual(false);
+});
+
+test("returns false for a negative proper fraction( absolute value of the denominator is less than the numerator)", () => {
+  expect(isProperFraction(-7, 4)).toEqual(false);
+});
+test("returns false when denominator is zero", () => {
+  expect(isProperFraction(3, 0)).toEqual(false);
+});

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

@@ -8,6 +8,27 @@ test("should return 11 for Ace of Spades", () => {
 });
 
 // Case 2: Handle Number Cards (2-10):
+test("should return the numeric value for number cards (2-10)", () => {
+  const fiveofHearts = getCardValue("5♥");
+  expect(fiveofHearts).toEqual(5);
+  const tenofHearts = getCardValue("10♥");
+  expect(tenofHearts).toEqual(10);
+});
 // Case 3: Handle Face Cards (J, Q, K):
+test("should return 10 for face cards (J, Q, K)", () => {
+  const kingofHearts = getCardValue("K♥");
+  expect(kingofHearts).toEqual(10);
+  const queenofHearts = getCardValue("Q♥");
+  expect(queenofHearts).toEqual(10);
+});
 // Case 4: Handle Ace (A):
+test("should return 11 for an Ace", () => {
+  const aceofHearts = getCardValue("A♥");
+  expect(aceofHearts).toEqual(11);
+});
+
 // Case 5: Handle Invalid Cards:
+test("should return invalid card rank", () => {
+  const twelveofHearts = getCardValue("12♥");
+  expect(twelveofHearts).toEqual("Invalid card rank");
+});