This repository was archived by the owner on Jan 3, 2023. It is now read-only.
Web Developer test #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparkwebdev
reviewed
Jun 26, 2017
index.html
Outdated
| @@ -0,0 +1,103 @@ | |||
| <!DOCTYPE> | |||
There was a problem hiding this comment.
Your HTML is nicely written and laid out, and you are using comments well.
Just double-check your doctype declaration here - you may run into issues when you are trying to validate your HTML. Compare with here: https://www.w3schools.com/tags/tag_doctype.asp
Author
There was a problem hiding this comment.
oops, yes I missed html
thanks for your feedback I will correct it.
sparkwebdev
reviewed
Jun 26, 2017
index.html
Outdated
| <h1 class="website-title">CYF</h1> | ||
| <!-- Navigate bar--> | ||
| <div class="navbar"> | ||
| <button id="Menu 1" type="button" class="btn btn-primary">Menu 1</button> |
There was a problem hiding this comment.
Be careful with spaces in your IDs and classnames - the browser will treat them as two separate ones (i) Menu and (ii) 1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Web Developer test First Revision