Skip to content
This repository was archived by the owner on Jan 3, 2023. It is now read-only.

Conversation

@MohamadAlissa
Copy link

Web Developer test First Revision

index.html Outdated
@@ -0,0 +1,103 @@
<!DOCTYPE>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your HTML is nicely written and laid out, and you are using comments well.

Just double-check your doctype declaration here - you may run into issues when you are trying to validate your HTML. Compare with here: https://www.w3schools.com/tags/tag_doctype.asp

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, yes I missed html
thanks for your feedback I will correct it.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect :)

index.html Outdated
<h1 class="website-title">CYF</h1>
<!-- Navigate bar-->
<div class="navbar">
<button id="Menu 1" type="button" class="btn btn-primary">Menu 1</button>
Copy link

@sparkwebdev sparkwebdev Jun 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be careful with spaces in your IDs and classnames - the browser will treat them as two separate ones (i) Menu and (ii) 1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants