Include links to original sources in success pages #1730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cyf-launch ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-common ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-sdc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-programming ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-curriculum ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-tracks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-itd ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for cyf-piscine ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This:
* Makes it easier to see what things are self-study vs have expected
evidence from backlog.
* Makes it easier to link back to where the topics were introduced.
The way we go about this is:
1. When fetching remote learning objectives, parse out to accumulate the
list of LOs, rather than just grabbing the whole markdown block
2. Pass LOs through a `{{<objectives>}}` shortcode, rather than just
pulling the shortcode in through the raw markdown.
3. Pass links to the original blocks into the rendering block.
4. Send both local and remote learning objectives through the same
rendering block (`common-theme/layouts/partials/objectives/for-success.html`)
which now includes links back.
illicitonion
force-pushed
the
success-page-links
branch
from
8f2897c to
11e16e9
Compare
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This:
The way we go about this is:
{{<objectives>}}shortcode, rather than just pulling the shortcode in through the raw markdown.common-theme/layouts/partials/objectives/for-success.html) which now includes links back.