Skip to content
This repository was archived by the owner on Jan 3, 2023. It is now read-only.

Dom-Ajax HomeWork #7

Open
khaledkzy wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Dom-Ajax HomeWork #7

khaledkzy wants to merge 2 commits into from

Conversation

@khaledkzy
Copy link

@khaledkzy khaledkzy commented Jul 10, 2017

No description provided.

zero-point
zero-point suggested changes Jul 12, 2017
View reviewed changes
Copy link
Member

@zero-point zero-point left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good work! Just needs the following changes:

  • there should be a check for when the email field is empty, as you did with name and description.

  • the '@' check isn't quite right, as indexOf returns -1 when it can't find the substring.

Irina :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@zero-point zero-point zero-point requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Scotland-Class-1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@khaledkzy @zero-point @kkarimi