fix: replaced SyntaxHighlighter to prism to fix react components#76
Open
idoo wants to merge 2 commits intoCodecrumbsIO:masterfrom
Open
fix: replaced SyntaxHighlighter to prism to fix react components#76idoo wants to merge 2 commits intoCodecrumbsIO:masterfrom
idoo wants to merge 2 commits intoCodecrumbsIO:masterfrom
Conversation
Collaborator
|
@idoo this newer version seems to have significant performance drop, it hangs on few sec when I open Code tab, see profiler below |
Contributor
Author
|
@Bogdan-Lyashenko could you show screen how it worked before? |
Collaborator
|
@idoo it was smooth :) i.e. it wasn't the issue, now it's quite visible (without even throttling or anything) that it's delays for few sec before render. Not sure what we should do, let's wait with this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
looks like language attribute broke it #59 — dropped it to fix highlight