feat: support for multiline comment for languages that use JS regex#82
Open
idoo wants to merge 14 commits intoCodecrumbsIO:masterfrom
Open
feat: support for multiline comment for languages that use JS regex#82idoo wants to merge 14 commits intoCodecrumbsIO:masterfrom
idoo wants to merge 14 commits intoCodecrumbsIO:masterfrom
Conversation
idoo
changed the title
Collaborator
|
@idoo I tested, it seems like something wrong with parsing. See screenshot from redux-state for codecrumb; pls check what's happing inside |
Collaborator
|
@idoo multiple crumbs in one file don't work. e.g. add |
| return []; | ||
| } | ||
|
|
||
| const result = fileCode.match(regex) || []; |
Collaborator
There was a problem hiding this comment.
@idoo match returns more than you need :)
if you run yarn server:two it will look like this
while in master it's like this
you can see there is an issue with example-project/src-server/app/service/user/session.py
Match returns
[ '#cc:signin#3;updare seesion',
'',
'cc:signin#3;updare seesion',
index: 0,
input: '#cc:signin#3;updare seesion' ]
there, so after filter by //cc you gonna have double '#cc:signin#3;updare seesion'
idoo
force-pushed
the
feature/multiline
branch
from
662479c to
ac772b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.