perf: optimizations for join and quit listeners#85
Open
DereC4 wants to merge 1 commit intoCodedRed-Spigot:mainfrom
Open
perf: optimizations for join and quit listeners#85DereC4 wants to merge 1 commit intoCodedRed-Spigot:mainfrom
DereC4 wants to merge 1 commit intoCodedRed-Spigot:mainfrom
Conversation
DereC4
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi i used ur thing for a long time on our forever survival server, mc.longhorns.dev (check it out sometime that would be so cool!)
wanted to take a peek and see what i could do to help this cool project
The original code was performing disk write operations directly on the Minecraft server's main thread during player join and quit events it appears. Wrapped some things in async which you already provided a great utility for @CodedRedGIT