Skip to content

🐛 fix(compose): allow compose files mounted outside app directory #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
s-b-e-n-s-o-n merged 10 commits into from
Mar 9, 2026
Merged

🐛 fix(compose): allow compose files mounted outside app directory #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
60f03f5
🐛 fix(compose): allow compose files mounted outside app directory
s-b-e-n-s-o-n Mar 9, 2026
e23b4f6
💄 style(docs): add RC banner to docs site matching website
s-b-e-n-s-o-n Mar 9, 2026
833706b
💄 style(docs): make RC banner red and fix version label
s-b-e-n-s-o-n Mar 9, 2026
0bab960
🔧 chore(docs): fix biome formatting in docs layout
s-b-e-n-s-o-n Mar 9, 2026
f5826ae
🐛 fix(compose): remap host paths to container paths and add trigger a…
s-b-e-n-s-o-n Mar 9, 2026
8087280
✅ test(compose): harden service matching and add YAML mutation safety…
s-b-e-n-s-o-n Mar 9, 2026
222985e
🔧 chore: fix biome formatting in compose trigger tests
s-b-e-n-s-o-n Mar 9, 2026
deb14ac
🔧 chore(lefthook): skip snyk scans on feature branches
s-b-e-n-s-o-n Mar 9, 2026
a112f5d
💄 style(docs): clarify RC banner stable link destination
s-b-e-n-s-o-n Mar 9, 2026
8a161b5
♻️ refactor(compose): harden bind mount loading and improve encapsula…
s-b-e-n-s-o-n Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

- **Compose trigger rejects compose files mounted outside app directory** — Removed overly strict working-directory boundary enforcement from `runComposeCommand` that rejected compose files bind-mounted outside `/home/node/app`, breaking documented mount patterns like `/drydock/docker-compose.yml`. Compose file paths are operator-configured and already validated during resolution.
- **Compose trigger uses host paths instead of container paths** — Docker label auto-detection (`com.docker.compose.project.config_files`) now remaps host-side paths to container-internal paths using Drydock's own bind mount information. Previously, host paths like `/mnt/volume1/docker/stacks/monitoring/compose.yaml` were used directly inside the container where they don't exist, causing "does not exist" errors even when the file was properly mounted.
- **Compose trigger logs spurious warnings for unrelated containers** — When multiple compose triggers are configured, each trigger now silently skips containers whose resolved compose files don't match the trigger's configured `FILE` path, eliminating noisy cross-stack "does not exist" warnings.
- **Silent error on recheck failure** — "Recheck for Updates" button now displays an error banner when the backend request fails instead of silently stopping the spinner with no feedback.
- **Silent error on env reveal failure** — Environment variable reveal in the container detail panel now shows an inline error message when the API call fails instead of silently failing.
- **Security scans persist across navigation** — Navigating away from the Security view no longer cancels in-flight batch scans. Module-scoped scan state survives unmount and the progress banner reappears on return.
Expand Down
Loading