🐛 fix(ci): retry qlty on timeout and increase limit to 8 minutes#131
Closed
s-b-e-n-s-o-n wants to merge 1 commit intomainfrom
Closed
🐛 fix(ci): retry qlty on timeout and increase limit to 8 minutes#131s-b-e-n-s-o-n wants to merge 1 commit intomainfrom
s-b-e-n-s-o-n wants to merge 1 commit intomainfrom
Conversation
retry_on was set to "error" which only retries on non-zero exit codes, not on timeouts. Changed to "any" so the 5-minute timeout actually triggers a retry. Also bumped timeout from 5 to 8 minutes since qlty regularly takes longer in CI.
s-b-e-n-s-o-n
requested review from
ALARGECOMPANY and
biggest-littlest
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Author
|
Folding into the next RC with compose Docker Engine API fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
retry_onfromerrortoanyso qlty timeouts actually trigger retriesContext
The Lint job failed on the main push after merging PR #129 —
qlty checkhit the 5-minute timeout butretry_on: erroronly retries on non-zero exit codes, not timeouts. The job failed on attempt 1 without retrying.