✅ test: Fixing retention test for update operations#137
Merged
s-b-e-n-s-o-n merged 1 commit intoCodesWhat:mainfrom Mar 12, 2026
Merged
Conversation
|
@Waler is attempting to deploy a commit to the CodesWhat Team on Vercel. A member of the Team first needs to authorize it. |
s-b-e-n-s-o-n
approved these changes
Mar 12, 2026
Contributor
s-b-e-n-s-o-n
left a comment
s-b-e-n-s-o-n
left a comment
There was a problem hiding this comment.
Clean fix — the original timestamps used local-time February dates that could land before the UTC insertion timestamps depending on timezone, causing retention pruning to pick the wrong operations. Bumping to March makes the update timestamps unambiguously newer. Tests pass. Thanks @Waler!
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
biggest-littlest
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test failed because the wrong 2 operations where left in the store after prune.
Reason: The 97 test updates on the third operation were executed with a timestamp earlier than the original operation timestamp. Therefore the third operation was defined as the oldest (by updatetime) of the three operations and pruned.