Conversation
- Updated public/index.html to add feather icons - Updated router to redirect to main view - Updated css files to add more colors and few adjustments - Updated logo.png - Added Main view - Added new components for the main layout within community directory - Added white and black sample logos Fixes CodingGarden#30 💚
- Updated public/index.html to add feather icons - Updated router to redirect to main view - Updated css files to add more colors and few adjustments - Updated logo.png - Added Main view - Added new components for the main layout within community directory - Added white and black sample logos Fixes CodingGarden#30 💚
nmigueles
left a comment
nmigueles
left a comment
There was a problem hiding this comment.
Hi @carlan,
First of all, this is amazing.
About Updated public/index.html to add feather icons, I think Cj prefers to use the svg of the icon directly.
I think that it gives you more control about the icon itself and avoids loading unused ones.
This is just a suggestion and would love to hear your opinion.
| <span>{{name}}</span> | ||
| </div> | ||
| <div class="actions" v-if="true"> | ||
| <i data-feather="user-plus" class="add"></i> |
There was a problem hiding this comment.
| <i data-feather="user-plus" class="add"></i> | |
| <svg class="add" viewBox="0 0 24 24" width="24" height="24" stroke="currentColor" stroke-width="2" fill="none" stroke-linecap="round" stroke-linejoin="round"><path d="M16 21v-2a4 4 0 0 0-4-4H5a4 4 0 0 0-4 4v2"></path><circle cx="8.5" cy="7" r="4"></circle><line x1="20" y1="8" x2="20" y2="14"></line><line x1="23" y1="11" x2="17" y2="11"></line></svg> |
There was a problem hiding this comment.
I was wondering about lots of things while doing the layout and kept my fingers out of many things intentionally. Otherwise, CJ won't have anything to show on stream 😉
My intentions with my PR's are create a starting point where CJ can pick where I left off and create content. Well, apart from the Docker one, that's a real fix.
Thanks.
There was a problem hiding this comment.
This is fine for now. Eventually we will remove feathers icons and use the icons shidotmoe created.
w3cj
left a comment
w3cj
left a comment
There was a problem hiding this comment.
Really awesome! Thanks for doing this!
I'd like to stick to BEM for css styles / class names. We can potentially setup a style linter to help catch these kind of errors.
| <span>{{name}}</span> | ||
| </div> | ||
| <div class="actions" v-if="true"> | ||
| <i data-feather="user-plus" class="add"></i> |
There was a problem hiding this comment.
This is fine for now. Eventually we will remove feathers icons and use the icons shidotmoe created.
|
As I mentioned on stream yeah will do the requested changes and update this pull request accordingly. In fact I already started but got caught in some work last week and couldn't carry on. However, as you mentioned the next stream of entropychat could be next weekend, I still have some days to finish and also a bit of extra time to go beyond and hook with backend. |
- Updated layout to apply BEM
…into feature/issue-30
- Hooked up with backend
3 participants
Updated the client application to add the layout for the main screen.
What was done:
Fixes #30 💚
Type of change
PR Checklist: